Skip to content

Export missing defaults when set False #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pdxlocations
Copy link
Member

Some older protobufs default to True. When users set them to False, they are excluded from --export-config. When using --configure, these keys are not set to False.

This PR sets these keys to False in --export-config if they are missing.

Copy link

codecov bot commented Jul 27, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 60.13%. Comparing base (172c123) to head (0261313).

Files with missing lines Patch % Lines
meshtastic/__main__.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #807      +/-   ##
==========================================
+ Coverage   60.05%   60.13%   +0.08%     
==========================================
  Files          24       24              
  Lines        4208     4219      +11     
==========================================
+ Hits         2527     2537      +10     
- Misses       1681     1682       +1     
Flag Coverage Δ
unittests 60.13% <90.90%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant