Skip to content

Conversation

pdxlocations
Copy link
Member

When firmware is built without these modules these requests just hang. This PR adds a 2 second delay before moving on.

@ianmcorvidae
Copy link
Contributor

Seems reasonable enough for now to get things working again for those cases. A 2s limits feels like it'd be a bit low for doing this over remote admin is my main concern. Would it be possible to move this handling into the export-config part, rather than within the node.py functions? A timeout isn't really a big deal with the individual commands the way it is with export, so I think it'd be fine if only that side has the extra handling.

@pdxlocations
Copy link
Member Author

A timeout isn't really a big deal with the individual commands the way it is with export, so I think it'd be fine if only that side has the extra handling.

In my (limited) testing --get-ringtone and --get-canned-messages would just hang with no indication of what was going on if the modules aren't installed, so maybe it's useful to keep the timeout and log message in node?

I've not tested with remote admin at all. What do you think a good delay before timeout would be?

@tw-peha
Copy link

tw-peha commented Aug 29, 2025

Tested the fix as is with my t-echo and it seems to fix issues/814.
I have canned messages installed, and no matter if it is on or off the export hangs indefinitely

@pdxlocations
Copy link
Member Author

pdxlocations commented Aug 29, 2025

I have canned messages installed, and no matter if it is on or off the export hangs indefinitely

Thanks for testing! For clarification, I believe the issue revolves around the modules being not included at all for for some targets. It doesn't matter if the module is on or off, only whether it's present.

Copy link

codecov bot commented Aug 29, 2025

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.97%. Comparing base (2b10459) to head (c87dc33).

Files with missing lines Patch % Lines
meshtastic/node.py 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #810      +/-   ##
==========================================
- Coverage   60.11%   59.97%   -0.15%     
==========================================
  Files          24       24              
  Lines        4217     4227      +10     
==========================================
  Hits         2535     2535              
- Misses       1682     1692      +10     
Flag Coverage Δ
unittests 59.97% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pdxlocations pdxlocations marked this pull request as draft August 29, 2025 23:30
@pdxlocations
Copy link
Member Author

Digging in a little deeper I find we have access to self.iface.metadata.excluded_modules bitmask. We could check which modules to exclude when calling these functions.

@pdxlocations
Copy link
Member Author

Closing in favor of #818

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants