-
Notifications
You must be signed in to change notification settings - Fork 295
Get smoke test 1 running again + include "is_unmessagable" in export/import of configurations #867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
juergenRe
wants to merge
15
commits into
meshtastic:master
Choose a base branch
from
juergenRe:karadoc/export-is_unmessagable
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Get smoke test 1 running again + include "is_unmessagable" in export/import of configurations #867
juergenRe
wants to merge
15
commits into
meshtastic:master
from
juergenRe:karadoc/export-is_unmessagable
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename variables and methods using camel case for uniformity within module
- simplifying code, removing copy/paste parts - configure "is_unmessagable" entry value
…and example.yaml - configuring channels via URL will delete all channel prior to load the new settings. - adding --fmt parameter for --nodes, otherwise pytest will always fail (problem seems to be located within tabulate library) - minor editing to avoid mix of camel and snake case
…ks also with WSL using serial line. (You have to auto-attach serial within WSL USB Manager)
…ux testing within WSL. We should have no special approach when testing on Linux. Moving send text message to a later point and using a private channel to not disturb everybody.
…ddional checks and waiting times to ensure that RAK can sustain those many requests and will able to finish internal operations. Improving logging: add capability to log into file, add timestamp of call and the command itself and visually clear separations of call to CLI. Deleting channels in the mid had some strange effects, added work-around to handle this case correctly. However, this might have side-effects when using deprecated admin channel. To be checked further!
…nly happens when reading a config. Adding additional protobuf files as exclusion to linter Smoke test 1: finalizing DEBUG/VERBOSE switches. Validating URL and QR functions in the right order. Systematic setup of test conditions.
…ne with snake_case first try to solve unit test issues - not finished
- mock node completely to be able to run configuration unit test - reset smoketest1 DEBUG settings
fix bug in url splitted over 2 lines minor changes in formatting
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of changes and motivation
Adding "is_unmessagable" to config
Idea was first to add the "is_unmessagable" flag to the export/import of configurations. This seemed to be a straight forward change not touching too much functions.
Problems with smoke test
After implementing this and starting with the smoke test, I found that 50% of those tests did not pass - far too much for me to be acceptable.
There have been several reasons for those problems:
In order to get smoke test running correctly, I had to add some missing functions, mainly on the node side and for channel handling. It turned out, that there is no (internal) function at all to reset all channels - which is at least needed when a configuration is loaded.
Test Results
Design Problems to be discussed further
What is then the function of the second, full URL? Will it overwrite just the channels which are defined and not touch the others? There might be users expecting that such an URL will just erase everything and set new occording to the URL. Has this been discussed already?
Detailed Changes
is_unmessagablefrom/to configuration fileargs.configure: extract common code, callsetOwner()once with all user settings. Ensure, that reading of yaml also works within pytest (read first text, then pass to yaml)args.showNodes: add parameterprintFmtto be able to force a json output circumventing table generation which always fails during testexport_config(): refactoring, adding types, cleaning codeshowChannels()to show everything, add function to delete all secondary channels (used inargs.config). Rewriting of a new channel list now starts at the end, so that the radio does never get double channel definitions during the update. Removinglogger.info()calls to streamline CLI output.--debugflag during the tests to store a debug log for later analysis. Store the current config temporarly and reload it at the end to avoid accidential operation in wrong region and to have the device always with a valid configuration. Reviewed all tests and improved/refined where necessary. Added a special configuration to reset channels to a known state before testing.test_main_configure_with_snake_case()andtest_main_configure_with_camel_case_keys()to do a real test (actually it did nothing because the config was not read correctly)