Skip to content

macros: use smp_mflags #14580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bmwiedemann
Copy link

use %{_smp_mflags}
to avoid embedding the number of CPU cores
in the .src.rpm header's expanded SPEC field.

See also rpm-software-management/rpm#2343

This patch was done while working on reproducible builds for openSUSE.

@bmwiedemann bmwiedemann requested a review from jpakkane as a code owner May 9, 2025 09:39
to avoid embedding the number of CPU cores
in the .src.rpm header's expanded SPEC field.

See also rpm-software-management/rpm#2343

This patch was done while working on reproducible builds for openSUSE.
Copy link
Member

@eli-schwartz eli-schwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole file is actually just entirely wrong as it doesn't delegate to %_ninja_build.

@bmwiedemann
Copy link
Author

If there was a PR for your proposal, I could test it.

@DimStar77
Copy link
Contributor

This whole file is actually just entirely wrong as it doesn't delegate to %_ninja_build.

imho, using %ninja_build would not be what one would expect.

%meson_build delegates the task to ninja by meson's code:

[  320s] INFO: autodetecting backend as ninja

If a packager wishes to rely on ninja_build, they could, but most distros will want to rely on meson/meson_build/meson_install as a default workflow

@eli-schwartz
Copy link
Member

If a packager wishes to rely on ninja_build, they could, but most distros will want to rely on meson/meson_build/meson_install as a default workflow

It is very interesting you should say that. The timing, especially.

Because I just had this conversation at muon-build/muon#148 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants