Remove user-custom VS Code settings #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would...
It's generally recommended that formatting stuff like formatOnSave and other such rules go in your own custom user-specific VS Code settings. In general, I think that .vscode/settings.json is more for project-specific patches on things like file extension association, extension customization (like enabling "Deno mode" for tsc checking) or other workspace-specific things.
This also helps encourage better formatting scripts like running
prettier -w .or similar to actually enforce these settings for all users even those using Neovim or JetBrains or whatever.Also on a popularity note, .vscode/settings.json files are relatively rare, especially in comparison to prettierrc files! 37k vs 101k and that's just the js prettier ecosystem! 😱
If there's a genuine workflow improvement or reason for this file to be here, then I'd love to hear it and add that explanation to the readme! ❤️ Documentation about code workflow stuff is a good thing 👍