-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#major): uniswap forks; add vapordex protocol #1440
Conversation
Hey @mejiasd3v thanks for the PR! One quick thing you can do is adding vaperdex to the deployment.json file like any of the other uniswap forks: https://github.com/messari/subgraphs/blob/master/deployment/deployment.json#L3044 I also kicked off our ci/cd pipeline, on the linting it looks like it wants you to change some variables to Like @this-username-is-taken said if you have any further questions feel free to browse our discord history or drop a question in there! |
thanks guys! |
…s depo status (messari#1449) Co-authored-by: Michael <[email protected]>
…g to GH issues (messari#1462) Co-authored-by: Michael <[email protected]>
Co-authored-by: dmelotik <[email protected]>
…essari#1463) Co-authored-by: Michael <[email protected]>
… csv download (messari#1471) Co-authored-by: Michael <[email protected]>
Co-authored-by: Tarun Madiraju <[email protected]> Co-authored-by: root <[email protected]> Co-authored-by: dmelotik <[email protected]>
) Co-authored-by: Michael <[email protected]>
…lay and logic (messari#1486) Co-authored-by: Michael <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mejiasd3v nice job! A few comments:
- To get the
build
ci job to pass you will need to add vapordex to our deployments.json file like so: https://github.com/messari/subgraphs/blob/master/deployment/deployment.json#L4041-L4069 more docs here - Once you have that you can then use the
messari-subgraph-cli
tool. I think that should fix the lint issue with configure.ts not having a const. But if not, that variable type should be aconst
not alet
Lastly, feel free to add me on discord: dylan#4435 just wanted to sync and see how the dev process was! Thanks
|
||
## Networks | ||
|
||
- Polygon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be avalanche I assume?
@@ -11,7 +11,6 @@ | |||
"npx": "^10.2.2" | |||
}, | |||
"devDependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you undo the changes in this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you got this by adding mustache to this package.json
. We recommend to add it globally to prevent this: https://github.com/messari/subgraphs/blob/master/docs/SETUP.md#installation
@@ -0,0 +1,62 @@ | |||
specVersion: 0.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you make this 0.0.4
startBlock: {{factory.startBlock}} | ||
mapping: | ||
kind: ethereum/events | ||
apiVersion: 0.0.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And Api versions 0.0.7
…essari#1821) Co-authored-by: Michael <[email protected]>
… deployment Ids (messari#1824) Co-authored-by: Michael <[email protected]>
Co-authored-by: Michael <[email protected]>
…y` for stable pools (messari#1608) Co-authored-by: Chris Steege <[email protected]>
…tor (messari#1841) Co-authored-by: Michael <[email protected]>
…sari#1843) Co-authored-by: Michael <[email protected]>
Co-authored-by: Michael <[email protected]>
Co-authored-by: Ishraq Alim <[email protected]>
Co-authored-by: Michael <[email protected]>
not quite sure what happened here... |
Hi 👋
I added VaporDEX fork
here is the link to the graph: https://okgraph.xyz/?q=mejiasd3v%2Fvapordex-avalanche
This is my first time creating a PR, please let me know if I'm missing something