Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#major): uniswap forks; add vapordex protocol #1440

Closed
wants to merge 253 commits into from

Conversation

mejiasd3v
Copy link

Hi 👋

I added VaporDEX fork

here is the link to the graph: https://okgraph.xyz/?q=mejiasd3v%2Fvapordex-avalanche

This is my first time creating a PR, please let me know if I'm missing something

@melotik
Copy link
Contributor

melotik commented Nov 21, 2022

Hey @mejiasd3v thanks for the PR! One quick thing you can do is adding vaperdex to the deployment.json file like any of the other uniswap forks: https://github.com/messari/subgraphs/blob/master/deployment/deployment.json#L3044

I also kicked off our ci/cd pipeline, on the linting it looks like it wants you to change some variables to const instead of let https://github.com/messari/subgraphs/actions/runs/3512869073/jobs/5895783489 .

Like @this-username-is-taken said if you have any further questions feel free to browse our discord history or drop a question in there!

@mejiasd3v
Copy link
Author

thanks guys!
@this-username-is-taken added you in Discord
@dmelotik will fix those linting issues

MichaelC1999 and others added 21 commits November 23, 2022 13:39
Co-authored-by: Tarun Madiraju <[email protected]>
Co-authored-by: root <[email protected]>
Co-authored-by: dmelotik <[email protected]>
Copy link
Contributor

@melotik melotik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mejiasd3v nice job! A few comments:

Lastly, feel free to add me on discord: dylan#4435 just wanted to sync and see how the dev process was! Thanks


## Networks

- Polygon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be avalanche I assume?

@@ -11,7 +11,6 @@
"npx": "^10.2.2"
},
"devDependencies": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you undo the changes in this file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you got this by adding mustache to this package.json. We recommend to add it globally to prevent this: https://github.com/messari/subgraphs/blob/master/docs/SETUP.md#installation

@@ -0,0 +1,62 @@
specVersion: 0.0.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make this 0.0.4

startBlock: {{factory.startBlock}}
mapping:
kind: ethereum/events
apiVersion: 0.0.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And Api versions 0.0.7

MichaelC1999 and others added 28 commits March 2, 2023 14:02
@melotik
Copy link
Contributor

melotik commented Mar 21, 2023

not quite sure what happened here...

@steegecs steegecs closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.