Fix bug in condition_on_observation

[jduerholt]

Motivation

Fix the bug outlined here: #3033

Tests are not yet adapted, first, I want to get your opinion on the fix ;)

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Unit tests, not yet adapted.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.98%. Comparing base (2591f32) to head (b3d4537).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##              main    #3034      +/-   ##
===========================================
- Coverage   100.00%   99.98%   -0.02%     
===========================================
  Files          216      216              
  Lines        20497    20531      +34     
===========================================
+ Hits         20497    20527      +30     
- Misses           0        4       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[hvarfner]

Hi @jduerholt ,

Thanks for spotting and fixing this. I haven't looked into it yet, but I'll start right away!

[saitcakmak]

Lgtm. I'll leave it to @hvarfner to give it a final look before merging.

[hvarfner]

This looks like a great solution to me! Did you have a test or two for this in the works, too?

[jduerholt]

I will file some tests over the weekend ;)

[meta-codesync]

@esantorella has imported this pull request. If you are a Meta employee, you can view this in D83766789.

[jduerholt]

Hi @hvarfner, I added a test that checks for the desired behavior. I was only wondering regarding one data structure issue, see my comment in the code ;) Best, Johannes

[facebook-github-bot]

@saitcakmak merged this pull request in 3ec2ab0.