Skip to content

support PrivateUse1 dispatch key into torchrec #3531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

support PrivateUse1 dispatch key into torchrec #3531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions torchrec/distributed/batched_embedding_kernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2367,6 +2367,11 @@ def __init__(
# Set EmbeddingLocation.HOST to make embedding op in FBGEMM choose CPU path.
# But the tensor will still be created on MTIA with device type "mtia".
managed.append(EmbeddingLocation.HOST)
elif device is not None and device.type == torch._C._get_privateuse1_backend_name():
compute_devices.append(ComputeDevice.PRIVATEUSE1)
managed.append(
compute_kernel_to_embedding_location(table.compute_kernel)
)
else:
compute_devices.append(ComputeDevice.CPU)
managed.append(EmbeddingLocation.HOST)
Expand Down Expand Up @@ -2480,6 +2485,7 @@ def __init__(
device is None
or device.type == "cpu"
or (not (torch.cuda.is_available() or torch.mtia.is_available()))
or (not (torch.get_device_module(device) and torch.get_device_module(device).is_available()))
)
self._emb_module: DenseTableBatchedEmbeddingBagsCodegen = (
DenseTableBatchedEmbeddingBagsCodegen(
Expand Down Expand Up @@ -3259,6 +3265,11 @@ def __init__(
# Set EmbeddingLocation.HOST to make embedding op in FBGEMM choose CPU path.
# But the tensor will still be created on MTIA with device type "mtia".
managed.append(EmbeddingLocation.HOST)
elif device is not None and device.type == torch._C._get_privateuse1_backend_name():
compute_devices.append(ComputeDevice.PRIVATEUSE1)
managed.append(
compute_kernel_to_embedding_location(table.compute_kernel)
)
else:
compute_devices.append(ComputeDevice.CPU)
managed.append(EmbeddingLocation.HOST)
Expand Down Expand Up @@ -3374,6 +3385,7 @@ def __init__(
device is None
or device.type == "cpu"
or (not (torch.cuda.is_available() or torch.mtia.is_available()))
or (not (torch.get_device_module(device) and torch.get_device_module(device).is_available()))
)
self._emb_module: DenseTableBatchedEmbeddingBagsCodegen = (
DenseTableBatchedEmbeddingBagsCodegen(
Expand Down
3 changes: 2 additions & 1 deletion torchrec/distributed/comm_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,8 @@ def _wait_impl(self) -> W:
"""

ret = self.wait_function.apply(self.pg, self, self.dummy_tensor)
if isinstance(ret, torch.Tensor) and ret.device.type == "cuda":
if isinstance(ret, torch.Tensor) and (ret.device.type == "cuda" or
ret.device.type == torch._C._get_privateuse1_backend_name()):
ret.record_stream(torch.get_device_module(ret.device).current_stream())
self.req = None
self.tensor = None
Expand Down
2 changes: 1 addition & 1 deletion torchrec/distributed/dist_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,7 +794,7 @@ def __init__(
# BUG: device will default to cuda if cpu specified
self._device_type: str = (
device.type
if device is not None and device.type in {"meta", "cuda", "mtia"}
if device is not None and device.type in {"meta", "cuda", "mtia", torch._C._get_privateuse1_backend_name()}
else "cuda"
)
assert self._world_size == len(splits)
Expand Down