fix RecMetrics loading (make trained_batches a buffer) #3534
+24
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
@prajjwal1 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86697665. |
prajjwal1
added a commit
to prajjwal1/torchrec
that referenced
this pull request
Nov 11, 2025
…3534) Summary: This diff addresses the following task: T209753398 Currently `trained_batches` is not stored in state_dict, requiring us to manually sync this variable upon checkpoint loading. We make this variable a buffer so that it can now be captured with model state dict. Differential Revision: D86697665
prajjwal1
force-pushed
the
export-D86697665
branch
from
4ae81ac to
f381d14
Compare
prajjwal1
added a commit
to prajjwal1/torchrec
that referenced
this pull request
Nov 11, 2025
…3534) Summary: This diff addresses the following task: T209753398 Currently `trained_batches` is not stored in state_dict, requiring us to manually sync this variable upon checkpoint loading. We make this variable a buffer so that it can now be captured with model state dict. Differential Revision: D86697665
prajjwal1
force-pushed
the
export-D86697665
branch
from
f381d14 to
deadc30
Compare
prajjwal1
added a commit
to prajjwal1/torchrec
that referenced
this pull request
Nov 11, 2025
…3534) Summary: This diff addresses the following task: T209753398 Currently `trained_batches` is not stored in state_dict, requiring us to manually sync this variable upon checkpoint loading. We make this variable a buffer so that it can now be captured with model state dict. Differential Revision: D86697665
prajjwal1
force-pushed
the
export-D86697665
branch
from
deadc30 to
c581e03
Compare
prajjwal1
added a commit
to prajjwal1/torchrec
that referenced
this pull request
Nov 11, 2025
…3534) Summary: This diff addresses the following task: T209753398 Currently `trained_batches` is not stored in state_dict, requiring us to manually sync this variable upon checkpoint loading. We make this variable a buffer so that it can now be captured with model state dict. Differential Revision: D86697665
prajjwal1
force-pushed
the
export-D86697665
branch
from
c581e03 to
127f92d
Compare
prajjwal1
added a commit
to prajjwal1/torchrec
that referenced
this pull request
Nov 11, 2025
…3534) Summary: This diff addresses the following task: T209753398 Currently `trained_batches` is not stored in state_dict, requiring us to manually sync this variable upon checkpoint loading. We make this variable a buffer so that it can now be captured with model state dict. Differential Revision: D86697665
prajjwal1
force-pushed
the
export-D86697665
branch
2 times, most recently
from
eaa4961 to
00a7b69
Compare
prajjwal1
added a commit
to prajjwal1/torchrec
that referenced
this pull request
Nov 11, 2025
…3534) Summary: This diff addresses the following task: T209753398 Currently `trained_batches` is not stored in state_dict, requiring us to manually sync this variable upon checkpoint loading. We make this variable a buffer so that it can now be captured with model state dict. Differential Revision: D86697665
prajjwal1
force-pushed
the
export-D86697665
branch
from
00a7b69 to
823b4d9
Compare
prajjwal1
added a commit
to prajjwal1/torchrec
that referenced
this pull request
Nov 12, 2025
…3534) Summary: This diff addresses the following task: T209753398 Currently `trained_batches` is not stored in state_dict, requiring us to manually sync this variable upon checkpoint loading. We make this variable a buffer so that it can now be captured with model state dict. Differential Revision: D86697665
prajjwal1
added a commit
to prajjwal1/torchrec
that referenced
this pull request
Nov 12, 2025
…3534) Summary: This diff addresses the following task: T209753398 Currently `trained_batches` is not stored in state_dict, requiring us to manually sync this variable upon checkpoint loading. We make this variable a buffer so that it can now be captured with model state dict. Differential Revision: D86697665
prajjwal1
force-pushed
the
export-D86697665
branch
from
823b4d9 to
7b2d64f
Compare
prajjwal1
added a commit
to prajjwal1/torchrec
that referenced
this pull request
Nov 12, 2025
…3534) Summary: This diff addresses the following task: T209753398 Currently `trained_batches` is not stored in state_dict, requiring us to manually sync this variable upon checkpoint loading. We make this variable a buffer so that it can now be captured with model state dict. Differential Revision: D86697665
prajjwal1
force-pushed
the
export-D86697665
branch
from
7b2d64f to
6208be6
Compare
…3534) Summary: This diff addresses the following task: T209753398 Currently `trained_batches` is not stored in state_dict, requiring us to manually sync this variable upon checkpoint loading. We make this variable a buffer so that it can now be captured with model state dict. Differential Revision: D86697665
prajjwal1
force-pushed
the
export-D86697665
branch
from
6208be6 to
df086d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff addresses the following task: T209753398
Currently
trained_batchesis not stored in state_dict, requiring us to manually sync this variable upon checkpoint loading. We make this variable a buffer so that it can now be captured with model state dict.Differential Revision: D86697665