feat: add TORCHX_IMAGE to env vars for Docker-based schedulers (#1128) #1129
+25
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
TORCHX_IMAGE
to environment variables so that we give a chance to the payload to record the value beyond the retention restrictions of the scheduler so as to facilitate reproducibility.Test plan:
[x] updated unit tests
[x]
local_docker --workspace ""
-> no image built or pushed -> we expect to see the base image inTORCHX_IMAGE
env varstorchx run -s local_docker --workspace "" utils.sh --image alpine:latest -- env
[x]
local_docker
-> image built locally, but not pushed -> we expect to see local image SHA inTORCHX_IMAGE
env varstorchx run -s local_docker utils.sh --image alpine:latest -- env
[x]
aws_batch --image_repo
-> image built locally, tagged and pushed to image repo -> we expect to see image tag inTORCHX_IMAGE
env varstorchx run -s aws_batch --scheduler_args 'queue=<queue-name>,priority=<priority>,image_repo=<image-repo>,share_id=<share-id>' utils.sh -h g5.4xlarge --image alpine:latest
Observe in Batch Job details: