Skip to content

[Celestica][m4052clsi] Add platform support for M4052CLSI. - #1955

Open
Alicewu-cls wants to merge 2 commits into
meta:mainfrom
Alicewu-cls:m4052clsi-add-m4052clsi-platform
Open

Alicewu-cls wants to merge 2 commits into
meta:mainfrom
Alicewu-cls:m4052clsi-add-m4052clsi-platform

Conversation

@Alicewu-cls

Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • [✓] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • [✓] pre-commit run
image

Summary

This PR introduces the full platform stack and core codebase support for M4052CLSI, a new Celestica platform based on the montblanc architecture.

Key Changes

  1. Platform Stack Configurations:
   - Added full platform stack configuration files under fboss/configs/platforms/celestica/m4052clsi/platform_stack/:
   - platform_manager.json: Configured with "platformName": "M4052CLSI", "rootPmUnitName": "M4052CLSI_MCB", and standardized non-prefixed FRU naming (`SCM`, `BMC`, `PDB_L`, `PDB_R`, `SMB`, etc.).
   - sensor_service.json, fan_service.json, fw_util.json, led_manager.json, bsp_tests.json, and rma_showtech.json.
  2. Platform Enumeration & Mapping:
   - fboss/lib/if/fboss_common.thrift: Defined platform enum PLATFORM_M4052CLSI = 61.
   - fboss/lib/platforms/PlatformProductInfo.cpp: Mapped model names "M4052CLSI" and "m4052clsi" to PLATFORM_M4052CLSI.
   - fboss/platform/helpers/PlatformNameLib.cpp: Normalized "M4052CLSI" and "M4052CLSI_MCB" to "M4052CLSI" in sanitizePlatformName().
  3. Platform Manager Validation:
   - fboss/platform/platform_manager/platform_manager_validators.thrift: Added "M4052CLSI_MCB" to ALLOWED_PMUNIT_NAMES.

Test Plan & Result

  1. Build Verification
    Successfully built all relevant platform binaries and test suites within development container:

  2. Testbed Functional Verification (Emulated Environment)

    • Verified binaries and configurations on an MP3 NL1.0 testbed by temporarily reprogramming EEPROMs to match the M4052CLSI identity.
    • PlatformManagerHwTest.ExploreAsDeployed: PASSED (Device exploration and symlink creation completed successfully for all FRUs).
    • sensor_service daemon & sensor_service_client: PASSED (Successfully queried and reported all sensor values across MCB, SCM, SMB, FCB, etc.).
    • PlatformHwTest.PCIDevicesPresent: PASSED.

Note

This is in early development with no hardware available for testing yet.

The functional verification above was performed on an MP3 NL1.0 system with modified EEPROM identities. This emulated setup was used to validate the configuration stack, driver probing, and daemon logic.

The physical M4052CLSI hardware is not yet available in the test lab, so on-target execution logs from an actual M4052CLSI system are not yet available.

Full physical validation will be conducted once the target hardware is delivered.

@Alicewu-cls
Alicewu-cls requested review from a team as code owners November 11, 2026 02:25
@meta-cla meta-cla Bot added the CLA Signed label Nov 11, 2026
@Alicewu-cls Alicewu-cls changed the title [Celestica][M4052CLSI] Add platform support for M4052CLSI [Celestica][m4052clsi] Add platform support for M4052CLSI Nov 11, 2026
@Alicewu-cls

Copy link
Copy Markdown
Contributor Author

Hi, @Scott8440 . Could you please add the NPI project name m4052clsi to the pr-projects.json file?

@Alicewu-cls

Copy link
Copy Markdown
Contributor Author

Add the log files from the basic FBOSS platform test run on the M4052CLSI unit with a DC PSU.

m4052clsi_log_1DCPSU.zip

@Alicewu-cls
Alicewu-cls force-pushed the m4052clsi-add-m4052clsi-platform branch from beb1e63 to 6692d71 Compare November 19, 2026 02:37
@Alicewu-cls Alicewu-cls changed the title [Celestica][m4052clsi] Add platform support for M4052CLSI [Celestica][m4052clsi] Add platform support for M4052CLSI. Nov 19, 2026
@github-actions github-actions Bot added the project:m4052clsi FBOSS project: m4052clsi label Nov 19, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants