Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
The OSS fan service currently calls
AsicTempThrift.getAsicTemp()on the fan-service agent endpoint, but the OSS deployment does not provide that method. This causes a recurringMethod name getAsicTemp not founderror every sensor cycle.Fix
fan_servicefetch ASIC temperature readings from the existingsensor_serviceThrift endpoint on port 5970.SensorDataentries to the fan-service ASIC-temperature response format.fan_serviceaftersensor_serviceand pull insensor_serviceat startup.fan_serviceis the consumer of thermal data; it does not need to expose a new temperature service.sensor_serviceis already the canonical OSS owner of platform sensor collection, timestamps, sensor types, and read-status handling, andfan_servicealready uses this same Thrift endpoint for its general sensor data. Reusing that supported API:wedge_agent/AsicTempThriftimplementation.Validation
git diff --checkpassed.main.PASS, and nogetAsicTemp/wedge_agenterrors or related cores were observed.dotslashlauncher installed.