Skip to content

[Cisco][bugfix] Fix fan service ASIC temperature source - #2018

Open
selekkala wants to merge 2 commits into
meta:mainfrom
selekkala:reopen/pr-1759-fan-service
Open

selekkala wants to merge 2 commits into
meta:mainfrom
selekkala:reopen/pr-1759-fan-service

Conversation

@selekkala

Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • I've run the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

The OSS fan service currently calls AsicTempThrift.getAsicTemp() on the fan-service agent endpoint, but the OSS deployment does not provide that method. This causes a recurring Method name getAsicTemp not found error every sensor cycle.

Fix

  • Make fan_service fetch ASIC temperature readings from the existing sensor_service Thrift endpoint on port 5970.
  • Convert temperature SensorData entries to the fan-service ASIC-temperature response format.
  • Preserve the existing FSDB path unchanged.
  • Order fan_service after sensor_service and pull in sensor_service at startup.

fan_service is the consumer of thermal data; it does not need to expose a new temperature service. sensor_service is already the canonical OSS owner of platform sensor collection, timestamps, sensor types, and read-status handling, and fan_service already uses this same Thrift endpoint for its general sensor data. Reusing that supported API:

  • Removes the dependency on the unavailable/proprietary wedge_agent/AsicTempThrift implementation.
  • Avoids adding a new wrapper service or duplicating hardware sensor access.
  • Keeps the temperature source consistent with the rest of OSS fan-service sensor handling.
  • Keeps FSDB-based deployments on their existing path.

Validation

  • git diff --check passed.
  • Patch applies cleanly to current upstream main.
  • Local FBOSS image build completed successfully with this change.
  • Runtime validation on the fixed image: ASIC temperatures were returned every 30 seconds, readings were fresh and PASS, and no getAsicTemp/wedge_agent errors or related cores were observed.
  • The focused Buck2 build was not run because this host does not have the repository dotslash launcher installed.

@selekkala
selekkala requested review from a team as code owners November 19, 2026 07:16
@meta-cla meta-cla Bot added the CLA Signed label Nov 19, 2026
@selekkala selekkala changed the title [Cisco] Fix fan service ASIC temperature source [Cisco][bugfix] Fix fan service ASIC temperature source Nov 19, 2026
@github-actions github-actions Bot added cisco project:bugfix FBOSS project: bugfix labels Nov 19, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants