Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
During ACL warmboot, FBOSS compares the ACL table attributes expected by FBOSS with the attributes read back from SAI/SDK.
When no UDF groups are configured, both sides mean “not configured,” but they use different values:
std::nullopt.optional(SAI_NULL_OBJECT_ID).The direct comparison treats these values as different. FBOSS then unnecessarily tries to recreate the ACL table. During that recreation,
recreateAclTable()dereferenced an expired SAI-store weak pointer without checking the result oflock(), causing the HW agent to terminate withSIGSEGV.Fix
optional(SAI_NULL_OBJECT_ID)asstd::nulloptfor the five ACL-table UDF attributes before comparing them.This prevents a false ACL-table mismatch and makes the recreation path safe when warmboot handles are stale or unavailable.
Test Plan
git diff --checkWARM_BOOTwithout an ACL attribute mismatch, ACL-table recreation, or HW-agent crash.