Skip to content

[Cisco][bugfix] Fix Morgan LED platform mapping - #2020

Open
selekkala wants to merge 3 commits into
meta:mainfrom
selekkala:reopen/pr-1718-morgan-led
Open

selekkala wants to merge 3 commits into
meta:mainfrom
selekkala:reopen/pr-1718-morgan-led

Conversation

@selekkala

Copy link
Copy Markdown
Contributor

Summary

The Morgan800CC LED service was constructing the default OSS platform mapping directly instead of using the descriptor-backed mapping selected for the platform. This prevented the selected platform mapping from being used by the LED service.

Change

  • Initialize Morgan800ccLedManager with Morgan800ccBspPlatformMapping and PlatformType::PLATFORM_MORGAN800CC.
  • Remove the direct dependency on the legacy Morgan800ccPlatformMapping implementation.
  • Preserve the existing platform-mapping override behavior.

Scope

This change is limited to:

fboss/led_service/Morgan800ccLedManager.cpp

No other LED managers or platform implementations are modified.

Validation

  • git diff --check passes.
  • The final diff against main contains only fboss/led_service/Morgan800ccLedManager.cpp.
  • Morgan800CC hardware validation confirmed the LED state changes to BLUE when the affected ports are up and OFF when they are down.

@selekkala
selekkala requested a review from a team as a code owner November 19, 2026 07:16
@meta-cla meta-cla Bot added the CLA Signed label Nov 19, 2026
@selekkala selekkala changed the title [Cisco] Fix Morgan LED platform mapping [Cisco][bugfix] Fix Morgan LED platform mapping Nov 19, 2026
@github-actions github-actions Bot added cisco project:bugfix FBOSS project: bugfix labels Nov 19, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants