Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pre-commit run --filesfor every modified file.Summary
fboss2 show bgp versioncurrently throws unconditionally in OSS builds because the Meta-internalgetRegexExportedValuesextension is unavailable.This change adds an additive
TBgpService.getBuildInfoRPC to the shared BGP Thrift definition and uses it only in the OSS CLI path. Internal builds retain the existing fb303 path. If the CLI reaches a pre-API daemon, it converts Thrift'sUNKNOWN_METHODresponse into an actionable upgrade-and-restart message.The BGP daemon-side handler lives in the separate
facebook/BGPrepository and must be deployed together with this client change. The compatibility error makes mixed-version rollout explicit rather than failing with the previous unsupported-command exception.Test Plan
pre-commit run --files cmake/CliFboss2Test.cmake fboss/cli/fboss2/commands/show/bgp/CmdShowVersionBgp.cpp fboss/cli/fboss2/test/CmdShowBgpVersionTest.cpp fboss/cli/fboss2/test/bgp/MockBgpClient.h neteng/fboss/bgp/if/bgp_thrift.thrift— passed.CmdShowBgpVersionTestFixture.QueryClientReturnsRunningBuildInfoto verify the CLI returns daemon-provided metadata.CmdShowBgpVersionTestFixture.QueryClientRejectsOldDaemonto verify the mixed-version compatibility error.Live OSS router validation logs (two switches)
Switch A:
Switch B:
Both switches had the BGP Thrift listener active and no BGP warnings or new coredumps during the validation window.
The focused C++ tests are included for CI execution; the production image used for runtime validation does not package test binaries.