Repository navigation
[Nexthop][m4061nhp] Fix the switch-card TMP464 channel mapping - #2025
Open
frank-nexthop wants to merge 1 commit into
Open
frank-nexthop wants to merge 1 commit into
frank-nexthop wants to merge 1 commit into
Conversation
The switch-card TMP464 has five channels, in hwmon order: temp1 local, temp2 near the FPGA, temp3 the ASIC thermal diode, temp4 near the ASIC, temp5 near the right PDC connector. The config followed an older four-channel mapping that put the ASIC diode on temp2, so the diode had board limits and two board sensors had diode limits, and temp5 was not read. Rename temp2-temp4 and set their limits to match, add temp5, and point the fan_service thermal shutdown conditions at the corrected sensors. Verified on hardware: after disabling all ports, only temp3 follows the ASIC's own temperature sensors. Signed-off-by: frank-nexthop <frank@nexthop.ai>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
The switch-card TMP464 on m4061nhp has five channels. The config followed an older four-channel mapping that put the ASIC thermal diode on
temp2. As a result, the diode was checked against the 92 C board limit, two board sensors were checked against the 122 C diode limit, andtemp5was not read at all.SWITCH_CARD_TMP464_LOCAL87/92ASIC_DIODE_0115/122SWITCH_CARD_NEAR_FPGA87/92SWITCH_CARD_NEAR_ASIC87/92ASIC_DIODE_0115/122SWITCH_CARD_PDC_INTAKE115/122SWITCH_CARD_NEAR_ASIC87/92SWITCH_CARD_NEAR_PDC_RIGHT87/92The fan_service thermal shutdown conditions now point at the corrected sensors, and
SWITCH_CARD_NEAR_PDC_RIGHTis added to them.numOvertempSensorForShutdownstays at 2, as on m4062nhp and m4340nhp.Test Plan
On an m4061nhp, I logged temp1-5 and the ASIC's own temperature sensors every 5 s, disabled all ports for 8 minutes, then re-enabled them. Only temp3 followed the ASIC: it dropped within 30 s, bottomed out at about 2 minutes and settled within about 2 minutes of re-enabling. The other channels cooled and recovered slowly, like the rest of the board. temp2, the old diode channel, fell steadily with no rebound.
I ran sensor_service and fan_service on the new configs. Every sensor named in the fan_service shutdown conditions was published with a normal reading, fan_service loaded the new conditions, and it reported no overtemperature. Both JSON files round-trip through
json.dumps(indent=2)unchanged.