Repository navigation
[Nexthop][m4061nhp] Monitor every DCDC and NVMe channel and add warning thresholds - #2026
Open
frank-nexthop wants to merge 2 commits into
Open
frank-nexthop wants to merge 2 commits into
frank-nexthop wants to merge 2 commits into
Conversation
The two switch-card ADM1266 DPMs sense the ASIC rails near the source, so under load they read 40-75 mV above the regulator output. For the 18 DPM channels whose rail is also made by a digital DCDC (DCDC0-10), drop the DPM sensor and add a DCDCn_<RAIL>_VOUT sensor that reads the regulator directly. That also adds the PT1/PT3/PT4/PT6 loops, which no DPM channel watches. DCDC0 iout1 replaces the DPM VDDC IMON channel. Thresholds mirror the limits the hwmon driver reports for each DCDC: DCDC1-10 only expose VOUT fault limits (lcrit/crit), so those rails get a critical band only; DCDC0 also exposes min/max, used as the alarm band. The 3V3 limits get the same 6/5 divider scaling as the reading. The adm1266 driver stays loaded, so the raw DPM values remain available outside sensor_service. Signed-off-by: frank-nexthop <frank@nexthop.ai>
platform_manager publishes many hwmon channels on m4061nhp that sensor_service did not read, and many rails had a critical band but no warning band. Add a sensor for every DCDC loop's VOUT, IOUT, POUT and power-stage temperature, each DCDC's 12 V input, VMON pin and controller temperature, DCDC0's input voltage, output power and controller temperature, and the NVMe per-sensor temperatures. Warning limits come from the board's rail ratings (maximum load current, times nominal VOUT for power), the 12 V and 5 V bands programmed on the switch-card ADM1266, and nominal +-5 % for rails whose regulator exposes only fault limits (the AVS rails span their allowed voltage range). Criticals stay at the regulator's programmed fault limits. Also add the missing PSU fan critical, PSU TEMP2 warning and management temperature sensor warning. Signed-off-by: frank-nexthop <frank@nexthop.ai>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Stacked on #1870, which adds the
DCDCn_<RAIL>_VOUTsensors this PR adds warning bands to. The first commit is #1870's; only the second commit is new here.On m4061nhp, platform_manager publishes many DCDC and NVMe hwmon channels that sensor_service doesn't read, and many rails have a critical band but no warning band. This PR adds 85 sensors and fills in missing limits on 35 existing ones:
The new IOUT warnings are each rail's maximum load current, and the POUT warnings are that current times the nominal VOUT. Criticals are the regulator's programmed fault limits. Input current and input power per loop are left out, because there is no limit to check them against.
Test Plan
On an m4061nhp, I loaded this config into sensor_service. It passed config validation, and all 217 sensors read inside their bands, with no read failures. Some sample readings (value, critical band, warning band):
fan_service kept all rotors healthy throughout. The JSON round-trips through
json.dumps(indent=2)unchanged, with no duplicate sensor names and no existing sensor removed.