Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): replaced authentication middleware with one intended for post requests. (Note: docker node 18 -> 20) #1152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrewsu31098
Copy link
Contributor

Problem

BB-813
The cbReviewModal is triggering a post request whose URL is being
stored and used as a redirection link later on during authentication.
This creates a redirection bug when a user attempts to sign in on any of the pages with said cbReviewModal.

  • edition groups
  • authors
  • series

Solution

The route handler for /critiquebrainz/refresh has been updated to use
isAuthenticatedForHandler (which authenticates without redirecting) instead of isAuthenticated which was filling in the redirect link.

Areas of Impact

  • Server /critiquebrainz/refresh post endpoint has been updated.
  • Docker Node Version updated from 18->20 due to version 18 Node's incompatibility with new Mocha Version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant