Revert exposed -web port from 8000 to 5001 #3339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haarg
approved these changes
Jun 1, 2025
There was a problem hiding this comment.
The reason I had changed the exposed port to be 8000 is that macOS uses port 5000 by default for its own purposes. Technically it is still possible to listen on port 5000 on localhost, but this can get confusing. And obviously port 5001 is not the same and is not occupied, but I was hoping to get away from the 5000/5001 pairing we were using previously. I had missed that GitHub has the port 5001 hard coded in its dev app.
I'm fine with merging this if it makes things easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.