Skip to content

Fix destroy event not firing #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix destroy event not firing #1304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f01942
Add failing test for destroy event firing
gpoole May 9, 2024
3319648
Fix destroy event not firing
gpoole May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,8 +837,8 @@ proto.deactivate = function() {
proto.destroy = function() {
this.deactivate();
window.removeEventListener( 'resize', this );
this.allOff();
this.emitEvent('destroy');
this.allOff();
if ( jQuery && this.$element ) {
jQuery.removeData( this.element, 'flickity' );
}
Expand Down
6 changes: 6 additions & 0 deletions test/unit/destroy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,18 @@ QUnit.test( 'destroy', function( assert ) {

let elem = document.querySelector('#destroy');
let flkty = new Flickity( elem );
let destroyFired = false;

flkty.on( 'destroy', () => {
destroyFired = true;
} );

let done = assert.async();
// do it async
setTimeout( function() {
flkty.destroy();
assert.strictEqual( elem.flickityGUID, undefined, 'flickityGUID removed' );
assert.ok( destroyFired, 'destroy event fired' );
assert.ok( !flkty.isActive, 'not active' );
assert.ok( !Flickity.data( elem ), '.data() returns falsey' );
assert.ok( elem.children[0], '.cell', 'cell is back as first child' );
Expand Down