Skip to content

Add packaging for Linux CPython x86_64#5

Merged
ksmyth merged 4 commits into
metamorph-inc:masterfrom
frodon1:master
Nov 14, 2024
Merged

Add packaging for Linux CPython x86_64#5
ksmyth merged 4 commits into
metamorph-inc:masterfrom
frodon1:master

Conversation

@frodon1
Copy link
Copy Markdown

@frodon1 frodon1 commented Oct 26, 2024

The packaging was added for CPython x86_64 on Linux, from python 3.7 to python 3.13.
Some porting was added in specific commits for portability to python 3.12 and 3.13.
Additional porting in the build procedure needs to be done for those versions on Windows.

The build mechanism for Linux is based on cibuildwheel.

@frodon1
Copy link
Copy Markdown
Author

frodon1 commented Oct 26, 2024

This PR fixes #1 and #3 on Linux.

@frodon1 frodon1 force-pushed the master branch 3 times, most recently from 851970c to 01b765d Compare October 28, 2024 18:02
@frodon1 frodon1 force-pushed the master branch 3 times, most recently from e94c67d to 7a0f5d4 Compare October 29, 2024 10:42
@frodon1
Copy link
Copy Markdown
Author

frodon1 commented Oct 29, 2024

@ksmyth any chance you can have a look at my PR ? Thanks !

@ksmyth
Copy link
Copy Markdown
Member

ksmyth commented Oct 30, 2024

Thanks for the PR. The Linux .whl looks good as far as I can tell. However, the Windows .whls changed.

  1. Could you please modify the build so that these files (and similarly-named) aren't included in the .whl:
omniORB/GNUmakefile
omniORB/GNUmakefile.in
omniORB/dir.mk
  1. COS/omniORB.pth contains omniORBCOS on windows, but omniORB/COS on Linux. Perhaps this is a backslash escape character error? But on Windows, the COS directory is installed directly in site-packages, which makes the .pth file unnecessary. So I think the best fix is to exclude this file on Windows.

Please make these changes, then I'll merge the PR.

@frodon1
Copy link
Copy Markdown
Author

frodon1 commented Oct 31, 2024

The corrections were made, the wheels for Windows seem fine now.
Best regards

@ksmyth ksmyth merged commit e9761cc into metamorph-inc:master Nov 14, 2024
@ksmyth
Copy link
Copy Markdown
Member

ksmyth commented Nov 14, 2024

Looks good, thanks very much.

@frodon1
Copy link
Copy Markdown
Author

frodon1 commented Nov 15, 2024

My pleasure, any idea when the linux wheels will be available on pypi?

@ksmyth
Copy link
Copy Markdown
Member

ksmyth commented Nov 20, 2024

"linux" wheels are rejected by pypi. The omniORB build has repair-wheel-command = "", which is the step that normally converts "linux" wheels into "manylinux" wheels. I don't know offhand how to make the repair-wheel work.

@frodon1
Copy link
Copy Markdown
Author

frodon1 commented Jan 13, 2025

Hello @ksmyth , please see my other PR #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants