Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.cfg -> pyproject.toml #2860

Merged
merged 7 commits into from
Mar 19, 2025
Merged

Conversation

MetRonnie
Copy link
Contributor

@MetRonnie MetRonnie commented Feb 25, 2025

This email is notifying you of an upcoming deprecation that we have determined may affect you as a result of your recent upload to 'metomi-rose'.

In the future, PyPI will require all newly uploaded source distribution filenames to comply with PEP 625. Any source distributions already uploaded will remain in place as-is and do not need to be updated.

Specifically, your recent upload of 'metomi-rose-2.4.1.tar.gz' is incompatible with PEP 625 because it does not contain the normalized project name 'metomi_rose'.

In most cases, this can be resolved by upgrading the version of your build tooling to a later version that supports PEP 625 and produces compliant filenames. You do not need to remove the file.

If you have questions, you can email [email protected] to communicate with the PyPI [email protected] to communicate with the PyPI administrators.

@MetRonnie MetRonnie added this to the 2.5.0 milestone Feb 25, 2025
Comment on lines 30 to +32
uses: actions/setup-python@v5
with:
# return to 3.x once cylc-flow is compatible with 3.10+ (pyuv)
python-version: '3.9'
python-version: '3.x'
Copy link
Contributor Author

@MetRonnie MetRonnie Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we needed to specify the setuptools version in pyproject.toml[build-system] in order to fix the PEP 625 incompatibility, but it turns out it was just that we needed to use a newer Python version for the build (the minimum version of setuptools that is compatible with PEP 625 is not available on Python 3.9)

Seeing as I'd done the legwork (with the help of Copilot), I've kept the pyproject.toml conversion.

@MetRonnie

This comment was marked as outdated.

@MetRonnie
Copy link
Contributor Author

Kicking tests

@MetRonnie MetRonnie closed this Mar 5, 2025
@MetRonnie MetRonnie reopened this Mar 5, 2025
@MetRonnie
Copy link
Contributor Author

@wxtim Do you want a 2nd reviewer?

@wxtim
Copy link
Contributor

wxtim commented Mar 5, 2025

@wxtim Do you want a 2nd reviewer?

I think it's worth it.

@MetRonnie
Copy link
Contributor Author

Can you request one then :)

@wxtim wxtim requested a review from oliver-sanders March 6, 2025 10:16
@MetRonnie MetRonnie marked this pull request as draft March 6, 2025 14:28
@MetRonnie MetRonnie marked this pull request as ready for review March 6, 2025 14:52
pyproject.toml Outdated
"flake8>=4.0.0",
"flake8>=6.0.0; python_version > '3.7'",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flake8 v5 is the last version compatible with Python 3.7. However this version has a pin on importlib-metadata which conflicts with our own. So we can't run Flake8 on Python 3.7 anymore.

@MetRonnie

This comment was marked as resolved.

@MetRonnie MetRonnie force-pushed the pyproject-toml branch 2 times, most recently from 0701182 to c8dd0f0 Compare March 17, 2025 13:11
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Tested running the tutorial workflow from a build to make sure files are being packaged correctly.

@oliver-sanders oliver-sanders merged commit c9ee60d into metomi:master Mar 19, 2025
17 checks passed
@MetRonnie MetRonnie deleted the pyproject-toml branch March 19, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants