-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup.cfg
-> pyproject.toml
#2860
Conversation
MetRonnie
commented
Feb 25, 2025
•
edited
Loading
edited
uses: actions/setup-python@v5 | ||
with: | ||
# return to 3.x once cylc-flow is compatible with 3.10+ (pyuv) | ||
python-version: '3.9' | ||
python-version: '3.x' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we needed to specify the setuptools
version in pyproject.toml[build-system]
in order to fix the PEP 625 incompatibility, but it turns out it was just that we needed to use a newer Python version for the build (the minimum version of setuptools that is compatible with PEP 625 is not available on Python 3.9)
Seeing as I'd done the legwork (with the help of Copilot), I've kept the pyproject.toml
conversion.
This comment was marked as outdated.
This comment was marked as outdated.
b611e11
to
644480f
Compare
Kicking tests |
@wxtim Do you want a 2nd reviewer? |
I think it's worth it. |
Can you request one then :) |
ef570f1
to
267a616
Compare
267a616
to
e655b3f
Compare
pyproject.toml
Outdated
"flake8>=4.0.0", | ||
"flake8>=6.0.0; python_version > '3.7'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flake8 v5 is the last version compatible with Python 3.7. However this version has a pin on importlib-metadata
which conflicts with our own. So we can't run Flake8 on Python 3.7 anymore.
db7a2a6
to
9579d6f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
0701182
to
c8dd0f0
Compare
c8dd0f0
to
192cd81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Tested running the tutorial workflow from a build to make sure files are being packaged correctly.