Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth via ADFS with MFA support #134

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

krutelp
Copy link

@krutelp krutelp commented Nov 17, 2020

Add MFA support for OAuth via ADFS.
Add rudimentary message dialog to visualize necessary MFA action.

Implemented MFA support for OAuth authentication via ADFS.
Added rudimentary message dialog to show notification sent to phone message to user.
@krutelp
Copy link
Author

krutelp commented Nov 18, 2020

@mguessan
Copy link
Owner

Thanks for your contribution, will merge this after a few checks

mguessan added a commit that referenced this pull request Nov 30, 2020
@mguessan
Copy link
Owner

Merged first commit, need some more time for the second one: O365Authenticator is supposed to be headless so user interaction was not an option.

However for SMS based authentication there is no way to provide code without such interaction
=> we wil need to support both graphical and command line user interaction

See certificate management for an example:

if (Settings.getBooleanProperty("davmail.server") || GraphicsEnvironment.isHeadless()) { // headless or server mode isCertificateTrusted = isCertificateTrusted(x509Certificates[0]); } else { isCertificateTrusted = AcceptCertificateDialog.isCertificateTrusted(x509Certificates[0]); }

@krutelp
Copy link
Author

krutelp commented Nov 30, 2020

I suggest to show graphical/console information also for case PhoneAppNotification. User should be informed about required action on smartphone. Is in graphical mode possible to show answer from server in some kind of HTML/JavaScript Java viewer in order to reduce MFA implementation effort?

@SimPilotAdamT
Copy link

I hate to be one of those guys who ask for ETAs, but it's been almost 4 years, and I'm in a pickle bc I need to use this with my MFA MS acc, and I can't because of the issue as reported in #180 and #363. Do we have any updates?

@SimPilotAdamT
Copy link

However for SMS based authentication there is no way to provide code without such interaction => we wil need to support both graphical and command line user interaction

iirc, both are now supported...

@krutelp
Copy link
Author

krutelp commented Jul 15, 2024

@SimPilotAdamT Hi, I'm not active in this PR anymore. You can take over.

@SimPilotAdamT
Copy link

I'm not active in this PR anymore. You can take over.

In that case I'm going to make my own fork so that I can make changes to the codebase, making it compatible with what's currently here. Going to try to make my own changes anyway, I don't have a lot of time in my hands...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants