Fix converter comments

Signed-off-by: Micah Hausler <[email protected]>
micahhausler · Dec 17, 2024 · 049d11e · 049d11e
1 parent 7162c50
commit 049d11e
Showing 1 changed file with 12 additions and 10 deletions.
diff --git a/cmd/converter/main.go b/cmd/converter/main.go
@@ -92,24 +92,25 @@ func main() {
 				}
 				ruler = convert.NewRoleRuler(*role)
 			}
-			if i > 0 {
-				fmt.Println()
-				fmt.Println("// ----------------------------------------------------------------------------------------------------------------")
-			}
-			fmt.Println("// " + binding.Name)
 			ps := convert.RoleBindingRulerToCedar(binding, ruler)
 			switch *format {
 			case "json":
 				data, _ := ps.MarshalJSON()
 				fmt.Println(string(data))
 			case "cedar":
+				if i > 0 {
+					fmt.Println()
+					fmt.Println("// ----------------------------------------------------------------------------------------------------------------")
+				}
+				fmt.Println("// " + binding.Name)
 				fmt.Println(string(ps.MarshalCedar()))
 			case "crd":
 				crd := CRDForCedarPolicy(binding.Name, ps)
 				data, err := yaml.Marshal(crd)
 				if err != nil {
 					klog.Fatalf("Error marshalling CRD: %v", err)
 				}
+				fmt.Println("# " + binding.Name)
 				fmt.Println(string(data))
 				if i != len(rbs.Items)-1 {
 					fmt.Println("---")
@@ -144,24 +145,25 @@ func main() {
 				klog.Errorf("Error getting ClusterRole %s: %v. Skipping this one", crb.RoleRef.Name, err)
 				continue
 			}
-			if i > 0 {
-				fmt.Println()
-				fmt.Println("// ----------------------------------------------------------------------------------------------------------------")
-			}
-			fmt.Println("// " + crb.Name)
 			ps := convert.ClusterRoleBindingToCedar(crb, *cr)
 			switch *format {
 			case "json":
 				data, _ := ps.MarshalJSON()
 				fmt.Println(string(data))
 			case "cedar":
+				if i > 0 {
+					fmt.Println()
+					fmt.Println("// ----------------------------------------------------------------------------------------------------------------")
+				}
+				fmt.Println("// " + crb.Name)
 				fmt.Println(string(ps.MarshalCedar()))
 			case "crd":
 				crd := CRDForCedarPolicy(crb.Name, ps)
 				data, err := yaml.Marshal(crd)
 				if err != nil {
 					klog.Fatalf("Error marshalling CRD: %v", err)
 				}
+				fmt.Println("# " + crb.Name)
 				fmt.Println(string(data))
 				if i != len(crbs.Items)-1 {
 					fmt.Println("---")