Fix not storing cookies at first install #81
+1
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komapa
reviewed
Mar 21, 2018
| @@ -53,6 +53,7 @@ HELP | |||
| _RESTY_DATA_DIR="$_RESTY_CONF_DIR" | |||
| fi | |||
| mkdir -p "$_RESTY_CONF_DIR" | |||
| mkdir -p "$_RESTY_CONF_DIR/c" | |||
There was a problem hiding this comment.
The -p is redundant or you can remove the mkdir call above. What you have now is the safest though.
pkeller
reviewed
Jul 14, 2022
| @@ -130,10 +130,6 @@ HELP | |||
| local editor="$_RESTY_EDITOR" | |||
| if [[ "POST PUT TRACE PATCH DELETE" =~ $method ]]; then local hasbody; hasbody="yes" ;fi | |||
|
|
|||
| if [ -d "$cookies" ] ; then # retrieve cookie | |||
There was a problem hiding this comment.
There is something not right here: why test whether the directory $cookies exists, and then do mkdir -p $cookies if it does?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if I was doing something wrong but after
The ~/.resty/c was not created and the cookies were not saved.
I had to create ~/.resty/c myself before the cookies were saved.
Also it looks like the previous code to create the cookie file only ran if the cookie file already exists and overwrote the host file (but not $_RESTY_HOST).