Skip to content

refactor: route writer-handle patching in tests through one helper #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michael-denyer merged 1 commit into from
Jul 26, 2026
Merged

refactor: route writer-handle patching in tests through one helper #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
276 changes: 0 additions & 276 deletions pyrefly-baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,282 +516,6 @@
"concise_description": "Expected a callable, got `Self@TestFilteringProperties`",
"severity": "error"
},
{
"line": 138,
"column": 30,
"stop_line": 138,
"stop_column": 48,
"path": "tests/test_incremental_writer.py",
"code": -2,
"name": "missing-attribute",
"description": "Object of class `NoneType` has no attribute `flush`",
"concise_description": "Object of class `NoneType` has no attribute `flush`",
"severity": "error"
},
{
"line": 146,
"column": 13,
"stop_line": 146,
"stop_column": 31,
"path": "tests/test_incremental_writer.py",
"code": -2,
"name": "missing-attribute",
"description": "Object of class `NoneType` has no attribute `flush`",
"concise_description": "Object of class `NoneType` has no attribute `flush`",
"severity": "error"
},
{
"line": 211,
"column": 30,
"stop_line": 211,
"stop_column": 48,
"path": "tests/test_incremental_writer.py",
"code": -2,
"name": "missing-attribute",
"description": "Object of class `NoneType` has no attribute `write`",
"concise_description": "Object of class `NoneType` has no attribute `write`",
"severity": "error"
},
{
"line": 222,
"column": 13,
"stop_line": 222,
"stop_column": 31,
"path": "tests/test_incremental_writer.py",
"code": -2,
"name": "missing-attribute",
"description": "Object of class `NoneType` has no attribute `write`",
"concise_description": "Object of class `NoneType` has no attribute `write`",
"severity": "error"
},
{
"line": 241,
"column": 38,
"stop_line": 241,
"stop_column": 56,
"path": "tests/test_incremental_writer.py",
"code": -2,
"name": "missing-attribute",
"description": "Object of class `NoneType` has no attribute `write`",
"concise_description": "Object of class `NoneType` has no attribute `write`",
"severity": "error"
},
{
"line": 248,
"column": 21,
"stop_line": 248,
"stop_column": 39,
"path": "tests/test_incremental_writer.py",
"code": -2,
"name": "missing-attribute",
"description": "Object of class `NoneType` has no attribute `write`",
"concise_description": "Object of class `NoneType` has no attribute `write`",
"severity": "error"
},
{
"line": 280,
"column": 38,
"stop_line": 280,
"stop_column": 56,
"path": "tests/test_incremental_writer.py",
"code": -2,
"name": "missing-attribute",
"description": "Object of class `NoneType` has no attribute `write`",
"concise_description": "Object of class `NoneType` has no attribute `write`",
"severity": "error"
},
{
"line": 287,
"column": 21,
"stop_line": 287,
"stop_column": 39,
"path": "tests/test_incremental_writer.py",
"code": -2,
"name": "missing-attribute",
"description": "Object of class `NoneType` has no attribute `write`",
"concise_description": "Object of class `NoneType` has no attribute `write`",
"severity": "error"
},
{
"line": 348,
"column": 30,
"stop_line": 348,
"stop_column": 48,
"path": "tests/test_incremental_writer.py",
"code": -2,
"name": "missing-attribute",
"description": "Object of class `NoneType` has no attribute `write`",
"concise_description": "Object of class `NoneType` has no attribute `write`",
"severity": "error"
},
{
"line": 358,
"column": 13,
"stop_line": 358,
"stop_column": 31,
"path": "tests/test_incremental_writer.py",
"code": -2,
"name": "missing-attribute",
"description": "Object of class `NoneType` has no attribute `write`",
"concise_description": "Object of class `NoneType` has no attribute `write`",
"severity": "error"
},
{
"line": 393,
"column": 30,
"stop_line": 393,
"stop_column": 48,
"path": "tests/test_incremental_writer.py",
"code": -2,
"name": "missing-attribute",
"description": "Object of class `NoneType` has no attribute `write`",
"concise_description": "Object of class `NoneType` has no attribute `write`",
"severity": "error"
},
{
"line": 404,
"column": 13,
"stop_line": 404,
"stop_column": 31,
"path": "tests/test_incremental_writer.py",
"code": -2,
"name": "missing-attribute",
"description": "Object of class `NoneType` has no attribute `write`",
"concise_description": "Object of class `NoneType` has no attribute `write`",
"severity": "error"
},
{
"line": 430,
"column": 38,
"stop_line": 430,
"stop_column": 56,
"path": "tests/test_incremental_writer.py",
"code": -2,
"name": "missing-attribute",
"description": "Object of class `NoneType` has no attribute `write`",
"concise_description": "Object of class `NoneType` has no attribute `write`",
"severity": "error"
},
{
"line": 439,
"column": 21,
"stop_line": 439,
"stop_column": 39,
"path": "tests/test_incremental_writer.py",
"code": -2,
"name": "missing-attribute",
"description": "Object of class `NoneType` has no attribute `write`",
"concise_description": "Object of class `NoneType` has no attribute `write`",
"severity": "error"
},
{
"line": 473,
"column": 21,
"stop_line": 473,
"stop_column": 39,
"path": "tests/test_incremental_writer.py",
"code": -2,
"name": "missing-attribute",
"description": "Object of class `NoneType` has no attribute `write`",
"concise_description": "Object of class `NoneType` has no attribute `write`",
"severity": "error"
},
{
"line": 525,
"column": 17,
"stop_line": 525,
"stop_column": 35,
"path": "tests/test_incremental_writer.py",
"code": -2,
"name": "missing-attribute",
"description": "Object of class `NoneType` has no attribute `flush`",
"concise_description": "Object of class `NoneType` has no attribute `flush`",
"severity": "error"
},
{
"line": 541,
"column": 34,
"stop_line": 541,
"stop_column": 52,
"path": "tests/test_incremental_writer.py",
"code": -2,
"name": "missing-attribute",
"description": "Object of class `NoneType` has no attribute `close`",
"concise_description": "Object of class `NoneType` has no attribute `close`",
"severity": "error"
},
{
"line": 547,
"column": 17,
"stop_line": 547,
"stop_column": 35,
"path": "tests/test_incremental_writer.py",
"code": -2,
"name": "missing-attribute",
"description": "Object of class `NoneType` has no attribute `close`",
"concise_description": "Object of class `NoneType` has no attribute `close`",
"severity": "error"
},
{
"line": 571,
"column": 30,
"stop_line": 571,
"stop_column": 48,
"path": "tests/test_incremental_writer.py",
"code": -2,
"name": "missing-attribute",
"description": "Object of class `NoneType` has no attribute `flush`",
"concise_description": "Object of class `NoneType` has no attribute `flush`",
"severity": "error"
},
{
"line": 586,
"column": 13,
"stop_line": 586,
"stop_column": 31,
"path": "tests/test_incremental_writer.py",
"code": -2,
"name": "missing-attribute",
"description": "Object of class `NoneType` has no attribute `flush`",
"concise_description": "Object of class `NoneType` has no attribute `flush`",
"severity": "error"
},
{
"line": 612,
"column": 38,
"stop_line": 612,
"stop_column": 56,
"path": "tests/test_incremental_writer.py",
"code": -2,
"name": "missing-attribute",
"description": "Object of class `NoneType` has no attribute `write`",
"concise_description": "Object of class `NoneType` has no attribute `write`",
"severity": "error"
},
{
"line": 622,
"column": 21,
"stop_line": 622,
"stop_column": 39,
"path": "tests/test_incremental_writer.py",
"code": -2,
"name": "missing-attribute",
"description": "Object of class `NoneType` has no attribute `write`",
"concise_description": "Object of class `NoneType` has no attribute `write`",
"severity": "error"
},
{
"line": 628,
"column": 21,
"stop_line": 628,
"stop_column": 38,
"path": "tests/test_incremental_writer.py",
"code": -2,
"name": "missing-attribute",
"description": "Object of class `NoneType` has no attribute `seek`",
"concise_description": "Object of class `NoneType` has no attribute `seek`",
"severity": "error"
},
{
"line": 606,
"column": 32,
Expand Down
Loading
Loading