Repository navigation
fix(shipping): use GitHub dequeue input id - #239
Merged
michael-denyer merged 1 commit intoOct 8, 2026
Merged
Conversation
Owner
|
Thanks for this, @alex-overcyai. The field name had been wrong since the code landed in September, and the schema link in your description made it quick to confirm against live introspection. Merged as fee271b. #240 follows up on the tests and is merged too. Both shipping test files now call one fake of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queued PR cancellation fails because the GraphQL request supplies
pullRequestId, butDequeuePullRequestInputrequiresid. Useidfor dequeue while retainingpullRequestIdfor disabling auto-merge. Continue passing the PR node ID and preserve every revision check and readback.Strengthen the transport and CLI fakes so they reject the invalid field. The targeted suite passes 28 tests. Restoring the old production request fails both new guards. Typechecking passes, and an independent reviewer reproduced the green and mutant runs with no findings.
The broader watcher suite reports 185 passes and an unchanged transport deadline test failing because its PID file is missing. That separate failure remains unresolved; this PR does not claim the full suite passes.
Contract verified against GitHub's current input schema and live schema introspection.