Deepen semantic rendering seams across all plotter families#22
Merged
Conversation
…poser The seam migration left adapter methods on LocusZoomPlotter that just forwarded to RegionalPlotComposer. Remove them and call the composer directly so there is no shim layer to keep in sync. - Drop _plot_association, _create_figure_with_heatmap, _render_heatmap_panel, _highlight_heatmap_snp, and _add_recombination_overlay from LocusZoomPlotter. - render_association_panel calls render_association_scatter itself; drop the draw_scatter callback and the AssociationScatter type alias. - ColocPlotter clips to the shared P_VALUE_FLOOR instead of a bare 1e-300, and loses the unused effect-legend adapters on ColocRenderer/ColocPlotter. - Tests patch composer.render_association_scatter, not the removed method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reworks every plotter family around explicit composition seams instead of one big method per plot doing data intake, layout, and rendering inline.
_data.pyowns p-value intake and the sharedP_VALUE_FLOOR. Coloc transforms two p-value columns at once, so it keeps its own-log10step but clips to the same floor rather than a bare1e-300._rendering.pyand_family_renderers.pyhold the per-family draw logic;_regional.pycomposes the association panel shared by single and stacked regional plots.supports_secondary_axis) through the base protocol, so the composer branches on a flag instead of knowing which backend it holds.LocusZoomPlotterare gone. Callers hitRegionalPlotComposerdirectly, so there is no shim layer to keep in sync.Families covered
Verification
uv run --extra dev pytest— 1111 passed, 1 skippeduv run --extra dev ruff check .uv run --extra dev ruff format --check .