Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix old comment, add some comments, free cmd and rsp #49

Closed
wants to merge 1 commit into from
Closed

Fix old comment, add some comments, free cmd and rsp #49

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 6, 2020

No description provided.

@ghost ghost closed this Apr 9, 2020
Copy link
Owner

@michaelforney michaelforney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I had typed up some comments, but forgot to submit.

@@ -4,3 +4,4 @@
/samu
/.ninja_deps
/.ninja_log
.vscode/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you can do here is add it to your .git/info/exclude. I don't want to start adding ignored files for every editor and IDE, only for the files produced during the build.

struct edge *gen;
/* list of edges that use this node as input, allocated and populated in graph.c:nodeuse */
struct edge **use;
/* number of edges in this.use */
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Duncaen already fixed this incorrect comment in #48, and I have just cherry-picked that patch.

I think "dependent edges" is a more succinct and precise way to describe this field.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant