-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add alt type #88
base: main
Are you sure you want to change the base?
add alt type #88
Conversation
Walkthrough今回の変更は、 Changes
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/types.ts (1)
65-65
: MicroCMSImageインターフェースへalt属性の追加は適切です!新しく追加された
alt?
プロパティは画像のアクセシビリティを向上させる重要な属性です。オプショナルとして実装されているため、後方互換性も維持されています。より明確にするために、プロパティのドキュメントを追加すると良いかもしれません:
export interface MicroCMSImage { url: string; width?: number; height?: number; + /** + * 画像の代替テキスト(アクセシビリティのため) + */ alt?: string; }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
メディアのalt機能のリリースに合わせた型の追加です。
既存のalt, 未入力のaltについてはaltの値は存在しないため、それに合わせた型となっています。
Summary by CodeRabbit