Fixed conversion string to temporalAmount - Duration or Period

[altro3]

Fixed #11577

[graemerocher]

@altro3 can you target 4.8.x?

[sdelamo]

@altro3 can you target 4.8.x?

I asked @altro3 to target 4.7.x as it was a bug introduced in 4.7.x. I will merge up @graemerocher

[dstepanov]

Why conversionService.convert("string", Duration) is triggering TemporalAccessor converter?

[altro3]

@dstepanov @graemerocher @sdelamo I would like to clarify that there is currently a bug in the Cookie interface in the maxAge method.

The argument is of the wrong type - TemporalAmount , but it should be Duration , because we are interested in the value in seconds, and Period stores the timestamp in days. From the TemporalAmount documentation:

* There are two common implementations.
* {@link Period} is a date-based implementation, storing years, months and days.
* {@link Duration} is a time-based implementation, storing seconds and nanoseconds,
* but providing some access using other duration based units such as minutes,
* hours and fixed 24-hour days.

I don't understand why TemporalAmount is there.

[sdelamo]

I would like to clarify that there is currently a bug in the Cookie interface in the maxAge method.
The argument is of the wrong type - TemporalAmount , but it should be Duration , because we are interested in the value in seconds, and Period stores the timestamp in days. From the TemporalAmount documentation:

but this should be a different pr right?

[altro3]

@sdelamo as you wish - I can add this correction to this PR too. :-) . Current fix - solve the problem. I just wanted to say that it is actually not correct to use TemporalAmount in this case

[altro3]

@sdelamo added this fix here. Don't think that we need to create different PR for it

[altro3]

@sdelamo can't fix it here, becuse also need to change micronaut-session module for it