fix: replace bare except with except Exception in image validation functions - #719
Open
surajthedev wants to merge 1 commit into
Open
fix: replace bare except with except Exception in image validation functions#719surajthedev wants to merge 1 commit into
surajthedev wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #707
Description
This PR replaces bare
except:clauses withexcept Exception:in imagevalidation functions, following Python best practices (PEP 8).
Changes
Replaced bare
except:withexcept Exception:in:Motivation
Bare
except:clauses catch all exceptions, includingSystemExitandKeyboardInterrupt, which can mask serious errors and prevent users fromstopping the program (e.g., via Ctrl+C). Using
except Exception:followsPEP 8 guidelines and prevents masking of critical system exceptions, while
still catching all legitimate errors like corrupt or invalid image files.
Testing
python -m py_compilepropagate properly