This repository has been archived by the owner on Sep 21, 2024. It is now read-only.
Refactor so shard / non-shard cases can use the same code #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shard / non-shard cases in CRA use different API. Ideally, we would have a base class for the common API and have the shard case inherit from the base class + either VertexBase or ShardedVertexBase. However, C# does not support multiple inheritence. To get around this, we move the initialized methods into an non-shard case that calls the original Ambrosia initialize function. This way we can easily add the sharded case. To make this cleaner and potentially easier to test, we move this logic into a different file.
added 2 commits
December 6, 2019 15:18
It's the same test as AMB_Basic_Test, except with shard params.
darrenge
force-pushed
the
master-update
branch
from
aa0b15a
to
52a2e49
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shard / non-shard cases in CRA use different API. Ideally,
we would have a base class for the common API and have the
shard case inherit from the base class + either VertexBase or
ShardedVertexBase. However, C# does not support multiple
inheritence.
To get around this, we move the initialized methods into an
non-shard case that calls the original Ambrosia initialize
function. This way we can easily add the sharded case.
To make this cleaner and potentially easier to test, we move this
logic into a different file.