Refactoring/Streamlining HttpClient creations#120
Merged
skg-marimuthu merged 2 commits intomainfrom Jan 5, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors HttpClient creation throughout the codebase to use a centralized HttpClientFactory that standardizes authentication, user agent, and content type headers. The factory reduces code duplication and ensures consistent header configuration across all HTTP requests.
- Introduces a new
HttpClientFactory.CreateAuthenticatedClient()method that handles Bearer token authentication and sets standard headers - Replaces all manual HttpClient instantiation and header configuration with factory calls
- Reorganizes using statements to follow Microsoft namespace ordering conventions
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| GraphApiService.cs | Updates constructor to use HttpClientFactory.CreateAuthenticatedClient() when no custom handler is provided |
| DelegatedConsentService.cs | Replaces manual HttpClient creation and authentication header setup with factory call |
| A365CreateInstanceRunner.cs | Refactors seven instances of HttpClient creation to use the factory for token acquisition, user operations, and Graph API calls |
| BlueprintSubcommand.cs | Converts four HttpClient instances to use factory pattern; reorders using statements and removes unused imports |
| PublishCommand.cs | Switches to factory-based HttpClient creation for MOS token-based operations; reorders using statements |
sellakumaran
previously approved these changes
Dec 20, 2025
pontemonti
reviewed
Dec 20, 2025
src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupSubcommands/BlueprintSubcommand.cs
Show resolved
Hide resolved
rahuldevikar761
previously approved these changes
Jan 5, 2026
skg-marimuthu
dismissed stale reviews from rahuldevikar761 and sellakumaran
via
a064ed6
pontemonti
approved these changes
Jan 5, 2026
mengyimicro
approved these changes
Jan 5, 2026
sellakumaran
pushed a commit
that referenced
this pull request
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring/Streamlining HttpClient creations and capture user agent