Run PowerShell script in MicrosoftGraphTokenProvider in interactive mode#142
Merged
pontemonti merged 2 commits intomainfrom Jan 7, 2026
Merged
Conversation
…s run in interactive mode.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the PowerShell execution logic in MicrosoftGraphTokenProvider by removing the conditional execution paths based on the useDeviceCode parameter. All token acquisition flows now consistently use interactive streaming mode, addressing issue #131.
Key Changes
- Removed the
useDeviceCodeparameter from internal methodsExecuteWithFallbackAsyncandExecutePowerShellAsync - Eliminated conditional logic that switched between
ExecuteAsync(for browser flow) andExecuteWithStreamingAsync(for device code flow) - Now always uses
ExecuteWithStreamingAsyncwithinteractive: truefor all authentication flows
src/Microsoft.Agents.A365.DevTools.Cli/Services/Internal/MicrosoftGraphTokenProvider.cs
Show resolved
Hide resolved
sellakumaran
previously approved these changes
Jan 6, 2026
sellakumaran
approved these changes
Jan 7, 2026
skg-marimuthu
approved these changes
Jan 7, 2026
This was referenced Jan 21, 2026
Closed
sellakumaran
pushed a commit
that referenced
this pull request
Feb 27, 2026
…ode (#142) * Update ExecutePowerShellAsync in MicrosoftGraphTokenProvider to always run in interactive mode. * Update tests --------- Co-authored-by: Johan Broberg <johanb@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update ExecutePowerShellAsync in MicrosoftGraphTokenProvider to always run in interactive mode.
This addresses the issue reported in #131