Add normalized location to delete endpoint call#145
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the location normalization logic in the BotConfigurator service by extracting it into a dedicated helper method. The change improves code maintainability by eliminating duplicate normalization code and ensures consistent location formatting across both endpoint creation and deletion operations.
Key changes:
- Extracted inline location normalization logic into a reusable
NormalizeLocationhelper method - Applied normalized location to the deletion endpoint request body and logging
- Fixed variable naming inconsistency in the delete method (renamed
createEndpointBodytodeleteEndpointBody)
mengyimicro
approved these changes
Jan 8, 2026
abdulanu0
approved these changes
Jan 8, 2026
sellakumaran
pushed a commit
that referenced
this pull request
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how Azure region locations are normalized in the
BotConfiguratorservice. The normalization logic, which converts display names like "Canada Central" into API-friendly names like "canadacentral", has been extracted into a dedicated helper method. This change improves maintainability and ensures consistent location formatting across endpoint creation and deletion operations.Refactoring and Consistency Improvements:
NormalizeLocationhelper method, replacing inline normalization in bothCreateEndpointWithAgentBlueprintAsandDeleteEndpointWithAgentBlueprintAsync. This ensures consistent formatting and easier future updates. [1] [2]DeleteEndpointWithAgentBlueprintAsyncmethod to use the normalized location value in both the request body and logging, aligning it with the creation workflow and preventing potential mismatches.