Sanitize JSON output before parsing in ClientAppValidator#147
Merged
sellakumaran merged 1 commit intomainfrom Jan 9, 2026
Merged
Sanitize JSON output before parsing in ClientAppValidator#147sellakumaran merged 1 commit intomainfrom
sellakumaran merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds JSON output sanitization before parsing Azure CLI responses in the ClientAppValidator service. The change addresses potential issues where Azure CLI on Windows can output control characters (like form feed) and warning messages that interfere with JSON parsing.
- Introduces
JsonDeserializationHelper.CleanAzureCliJsonOutput()call before allJsonNode.Parse()operations - Updates 7 locations where Azure CLI JSON output is parsed
- Adds import for the Services.Helpers namespace
sellakumaran
approved these changes
Jan 8, 2026
mengyimicro
approved these changes
Jan 8, 2026
sellakumaran
pushed a commit
that referenced
this pull request
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.