Add PR Review Skill for Claude Code by sellakumaran · Pull Request #182 · microsoft/Agent365-devTools

sellakumaran · 2026-01-24T04:52:46Z

Summary

Adds a reusable PR review skill for Claude Code that generates AI-powered, engineering-principles-based review comments.

Features

Comprehensive file analysis: Reviews ALL files (code, workflows, configs, docs, dependencies)
Context-aware reviews: Differentiates between CLI code (strict) and GitHub Actions code (lenient)
Engineering principles enforcement: KISS, DRY, SOLID, YAGNI, az cli patterns
Specific refactoring suggestions: File-based recommendations for splitting large files
Two-step workflow: Generate review → Edit YAML → Post to GitHub
Automatic fallback: Generates markdown for manual posting if API access fails
Editable output: YAML file format for easy review and modification

Usage

Generate review: /review-pr <pr-number>
Edit the generated YAML file as needed
Post to GitHub: /review-pr <pr-number> --post

Engineering Principles

The skill enforces:

.NET architect patterns and best practices
Azure CLI alignment and conventions
Cross-platform compatibility (for CLI code)
Testing requirements (blocking for CLI, high for Actions)
Security best practices (no hardcoded secrets)
Code quality standards (SOLID, one class per file, max 500 lines)

Files Added

.claude/skills/review-pr/SKILL.md - Skill definition with YAML frontmatter
.claude/skills/review-pr/review-pr.py - Implementation script
.claude/skills/review-pr/README.md - Documentation

What Gets Reviewed

Code files (Python, JS, TS, C#, Java, Go, etc.)
Workflow files (.github/workflows/*.yml)
Config files (YAML, JSON, TOML, etc.)
Dependency files (requirements.txt, package.json, etc.)
Documentation files
Any other modified files with general review guidance

Review Comments Include

Missing tests (blocking for CLI, high for Actions)
Large files >500 lines (specific splitting suggestions)
Workflow security and best practices
Config file validation
Dependency security checks
Cross-platform compatibility (CLI only)
Potential security issues

Output Format

Generated reviews are saved to:
C:\Users\<username>\AppData\Local\Temp\pr-reviews\pr-<number>-review.yaml

Comments can be:

Enabled/disabled
Modified
Severity adjusted (blocking, high, medium, low, info)

Test Plan

Skill loads in Claude Code
Generate review for PR GitHub Auto-Triage Action with AI-Powered Fix Suggestions #180 (21 files, 7 comments)
Reviews all file types (code, workflows, configs)
Context-aware analysis (CLI vs Actions)
Specific refactoring suggestions generated
YAML output is editable
Automatic markdown fallback on API failure

🤖 Generated with Claude Code

Co-authored-by: sellakumaran <147754920+sellakumaran@users.noreply.github.com>

Add logic to confirm Website Contributor role assignment for the current user after attempting assignment. If verification fails, log detailed warnings and manual remediation steps. Update tests to cover verification scenarios, including cases where the role already exists or assignment/verification fails, and assert correct logging and command execution.

Update log instructions to specify --endpoint-only for endpoint cleanup/registration in BlueprintSubcommand and BotConfigurator. Refine InfrastructureSubcommandTests mocks: webapp show now simulates post-creation success, signed-in-user returns valid GUID, and role assignment verification returns empty result for realism. Improves user guidance and test reliability.

- Context-aware review: Differentiates CLI vs GitHub Actions code - Actionable refactoring suggestions for large files - Engineering principles: KISS, DRY, SOLID, YAGNI - Test coverage requirements (blocking for CLI, high for actions) - Cross-platform checks (CLI only) - Security: Context-aware credential guidance - Windows encoding fixes for subprocess Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

- Rename skill.yaml to SKILL.md with YAML frontmatter - Use proper Claude Code skills format (Agent Skills standard) - Add markdown documentation in SKILL.md - Skill should now be discoverable in Claude Code Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

…ist all file types

Copilot

Pull request overview

This PR introduces a Claude Code /review-pr skill for generating/editing/posting structured PR review comments, and also enhances the CLI’s Azure infrastructure setup by attempting to assign the current user the Website Contributor role (plus associated tests) and updating endpoint-cleanup guidance to use --endpoint-only.

Changes:

Add a new Claude skill implementation (.claude/skills/review-pr/) that generates YAML-based review output and can post via gh.
Update InfrastructureSubcommand.CreateInfrastructureAsync to assign/verify “Website Contributor” for the current signed-in user, with new unit tests covering success/failure paths.
Update CLI log guidance to reference a365 cleanup blueprint --endpoint-only, and ignore locally generated PR review artifacts.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 17 comments.

Show a summary per file

File	Description
`src/Tests/.../InfrastructureSubcommandTests.cs`	Adds tests for Website Contributor role assignment behavior during infra creation.
`src/.../Services/BotConfigurator.cs`	Updates user guidance strings to use `--endpoint-only` for endpoint cleanup.
`src/.../Commands/SetupSubcommands/InfrastructureSubcommand.cs`	Adds Azure role assignment + verification for current user on the web app scope.
`src/.../Commands/SetupSubcommands/BlueprintSubcommand.cs`	Updates endpoint registration troubleshooting guidance to use `--endpoint-only`.
`.gitignore`	Ignores locally generated PR review markdown artifacts.
`.claude/skills/review-pr/review-pr.py`	Adds the PR review generator/poster script (YAML output + `gh` integration).
`.claude/skills/review-pr/SKILL.md`	Defines the Claude Code skill metadata and usage.
`.claude/skills/review-pr/README.md`	Documents setup/usage for the new `/review-pr` skill.

src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupSubcommands/InfrastructureSubcommand.cs

.claude/skills/review-pr/review-pr.py

.claude/skills/review-pr/README.md

src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Commands/InfrastructureSubcommandTests.cs

.claude/skills/review-pr/review-pr.py

Replaced all hardcoded references to "toolingManifest.json" and "ToolingManifest.json" with McpConstants.ToolingManifestFileName. Updated command classes, helpers, validation, and tests for consistent manifest file handling and improved error/log messages.

This reverts commit d8fdb17.

Copilot

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.

.claude/skills/review-pr/review-pr.py

.claude/skills/review-pr/README.md

src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupSubcommands/InfrastructureSubcommand.cs

This update adds deep, context-sensitive code analysis to the PR review tool, leveraging engineering principles and repository guidelines. Key improvements include: - Parsing PR diffs to analyze added/modified code per file. - Loading and applying rules from .github/copilot-instructions.md. - Automated checks for legacy keywords, copyright headers, large functions, resource leaks, code duplication, hardcoded secrets, workflow permissions, and test quality. - Contextual feedback based on PR intent (bug fix, feature, security, etc.). - Improved file categorization and more actionable, principle-driven review comments. - Refactored large file checks to be context-aware and updated the main flow to ensure all analyses have the necessary context. These changes transform the script into a robust, best-practice-enforcing code review assistant.

Resolved conflict in .gitignore by keeping both PR review patterns and Python ignores. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

github-actions · 2026-02-11T19:50:24Z

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copilot

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 14 comments.

.claude/skills/review-pr/review-pr.py

.claude/skills/review-pr/README.md

.claude/skills/review-pr/review-pr.py

.claude/skills/review-pr/SKILL.md

.claude/skills/review-pr/review-pr.py

Copilot AI and others added 11 commits January 23, 2026 16:14

Initial plan

8f87cd1

Add WebApp owner role assignment feature with tests

af897fa

Co-authored-by: sellakumaran <147754920+sellakumaran@users.noreply.github.com>

Add GUID validation for user object ID to prevent command injection

d838dc2

Co-authored-by: sellakumaran <147754920+sellakumaran@users.noreply.github.com>

Change workflow: default generates review, --post flag posts to GitHub

c9e0c5c

Add automatic markdown fallback when GitHub API posting fails

894d828

Review ALL files in PR: add workflow, config, dependency checks and l…

f1db34d

…ist all file types

Add pr-review markdown files to .gitignore

5b80a48

mengyimicro previously approved these changes Jan 24, 2026

View reviewed changes

sellakumaran marked this pull request as ready for review February 11, 2026 00:59

Copilot AI review requested due to automatic review settings February 11, 2026 00:59

sellakumaran requested review from a team as code owners February 11, 2026 00:59

Copilot started reviewing on behalf of sellakumaran February 11, 2026 00:59 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

sellakumaran dismissed mengyimicro’s stale review via d8fdb17 February 11, 2026 01:24

Revert "Standardize ToolingManifest file name usage"

83b3238

This reverts commit d8fdb17.

Copilot AI review requested due to automatic review settings February 11, 2026 01:30

Copilot started reviewing on behalf of sellakumaran February 11, 2026 01:30 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

tmlsousa previously approved these changes Feb 11, 2026

View reviewed changes

sellakumaran dismissed tmlsousa’s stale review via 7493822 February 11, 2026 19:45

Merge main into users/sellak/prSkill

d0c3299

Resolved conflict in .gitignore by keeping both PR review patterns and Python ignores. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings February 11, 2026 19:50

Copilot started reviewing on behalf of sellakumaran February 11, 2026 19:51 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

mengyimicro approved these changes Feb 11, 2026

View reviewed changes

skg-marimuthu approved these changes Feb 11, 2026

View reviewed changes

joratz approved these changes Feb 11, 2026

View reviewed changes

sellakumaran enabled auto-merge (squash) February 11, 2026 20:39

sellakumaran merged commit 00bc830 into main Feb 11, 2026
14 checks passed

sellakumaran deleted the users/sellak/prSkill branch February 11, 2026 20:41

Conversation

sellakumaran commented Jan 24, 2026

Summary

Features

Usage

Engineering Principles

Files Added

What Gets Reviewed

Review Comments Include

Output Format

Test Plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 11, 2026

Dependency Review

Scanned Files

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants