Support Custom Permissions through develop add-permissions#218
Closed
JesuTerraz wants to merge 33 commits intomainfrom
Closed
Support Custom Permissions through develop add-permissions#218JesuTerraz wants to merge 33 commits intomainfrom
develop add-permissions#218JesuTerraz wants to merge 33 commits intomainfrom
Conversation
…sers/jterrazas/develop-add-permission-mcs
…sers/jterrazas/develop-add-permission-mcs
* Initial plan * Address code review feedback: logging, validation, and documentation fixes Co-authored-by: JesuTerraz <96103167+JesuTerraz@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JesuTerraz <96103167+JesuTerraz@users.noreply.github.com>
…hub.com/microsoft/Agent365-devTools into users/jterrazas/resource-flag-get-token
…rrazas/develop-add-permission-mcs
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
develop add-permissionsdevelop add-permissions
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for targeting non-default resource APIs when using a365 develop add-permissions, aligning the command with the custom-resource support previously added to a365 develop get-token by centralizing resource keyword/ID resolution.
Changes:
- Introduces
ResourceResolutionHelper+ResolvedResourceto resolvemcp/powerplatformkeywords and custom resource GUIDs, with shared validation and error messages. - Extends
develop add-permissionsto accept--resource/--resource-idand routes bothadd-permissionsandget-tokenthrough the shared resolver. - Adds unit tests for the new resolver and updates command tests; updates
develop add-permissionsdocumentation for the new resource support.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.Agents.A365.DevTools.Cli/Helpers/ResourceResolutionHelper.cs | New shared resource/keyword resolution + validation helper used by multiple commands. |
| src/Microsoft.Agents.A365.DevTools.Cli/Constants/ErrorMessages.cs | Adds standardized error messages for resource resolution failures. |
| src/Microsoft.Agents.A365.DevTools.Cli/Commands/DevelopSubcommands/GetTokenSubcommand.cs | Replaces local resource-resolution logic with ResourceResolutionHelper. |
| src/Microsoft.Agents.A365.DevTools.Cli/Commands/DevelopSubcommands/AddPermissionsSubcommand.cs | Adds --resource / --resource-id options and uses shared resource resolver. |
| src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Helpers/ResourceResolutionHelperTests.cs | New unit tests covering resource resolution behavior and error messaging. |
| src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Commands/AddPermissionsSubcommandTests.cs | Updates command-option expectations for new resource options. |
| docs/commands/develop/develop-addpermissions.md | Updates docs to describe multi-resource permission addition. |
src/Microsoft.Agents.A365.DevTools.Cli/Commands/DevelopSubcommands/AddPermissionsSubcommand.cs
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Constants/ErrorMessages.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
src/Microsoft.Agents.A365.DevTools.Cli/Commands/DevelopSubcommands/AddPermissionsSubcommand.cs
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/DevelopSubcommands/AddPermissionsSubcommand.cs
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/DevelopSubcommands/GetTokenSubcommand.cs
Show resolved
Hide resolved
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Helpers/ResourceResolutionHelperTests.cs
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Helpers/ResourceResolutionHelper.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
src/Microsoft.Agents.A365.DevTools.Cli/Commands/DevelopSubcommands/AddPermissionsSubcommand.cs
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/DevelopSubcommands/GetTokenSubcommand.cs
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Helpers/ResourceResolutionHelper.cs
Outdated
Show resolved
Hide resolved
added 2 commits
February 10, 2026 14:45
…github.com/microsoft/Agent365-devTools into users/jterrazas/develop-add-permission-mcs
sellakumaran
requested changes
Feb 11, 2026
Contributor
sellakumaran
left a comment
There was a problem hiding this comment.
Had an offline discussion with Jesus and shared comments.
src/Microsoft.Agents.A365.DevTools.Cli/Commands/DevelopSubcommands/AddPermissionsSubcommand.cs
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/DevelopSubcommands/AddPermissionsSubcommand.cs
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/DevelopSubcommands/AddPermissionsSubcommand.cs
Show resolved
Hide resolved
Contributor
Author
|
Closing as some of this work will be picked up when adding generic permissions support as discussed with Sella |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
develop get-token#224 by merging similar logic for custom resources.