Skip to content

Improve resilience, logging, and code maintainability for Publish and Deploy commands. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sellakumaran merged 2 commits into from
Nov 17, 2025
Merged

Improve resilience, logging, and code maintainability for Publish and Deploy commands. #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e96256e
Improve resilience, logging, and code maintainability
sellakumaran Nov 17, 2025
e1831f1
Fix log message and clarify Python build comment
sellakumaran Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions src/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,38 +4,32 @@
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
<CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
</PropertyGroup>

<ItemGroup>
<!-- CLI Framework -->
<PackageVersion Include="Polly" Version="8.6.4" />
<PackageVersion Include="System.CommandLine" Version="2.0.0-beta4.22272.1" />

<!-- Configuration & JSON -->
<PackageVersion Include="Microsoft.Extensions.Configuration" Version="9.0.1" />
<PackageVersion Include="Microsoft.Extensions.Configuration.Json" Version="9.0.1" />
<PackageVersion Include="Microsoft.Extensions.Configuration.Binder" Version="9.0.1" />
<PackageVersion Include="System.Text.Json" Version="9.0.2" />

<!-- Security -->
<PackageVersion Include="Microsoft.Identity.Client" Version="4.78.0" />
<PackageVersion Include="System.Security.Claims" Version="4.3.0" />
<PackageVersion Include="System.Security.Principal" Version="4.3.0" />

<!-- Logging -->
<PackageVersion Include="Microsoft.Extensions.Logging" Version="9.0.1" />
<PackageVersion Include="Microsoft.Extensions.Logging.Console" Version="9.0.1" />
<PackageVersion Include="Serilog" Version="3.1.1" />
<PackageVersion Include="Serilog.Extensions.Logging" Version="8.0.0" />
<PackageVersion Include="Serilog.Sinks.Console" Version="5.0.1" />
<PackageVersion Include="Serilog.Sinks.File" Version="5.0.0" />

<!-- Azure SDKs -->
<PackageVersion Include="Azure.Identity" Version="1.13.2" />
<PackageVersion Include="Azure.ResourceManager" Version="1.13.2" />
<PackageVersion Include="Azure.ResourceManager.AppService" Version="1.2.0" />

<!-- Microsoft Graph -->
<PackageVersion Include="Microsoft.Graph" Version="5.36.0" />

<!-- Testing packages -->
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
<PackageVersion Include="xunit" Version="2.9.2" />
Expand All @@ -44,11 +38,9 @@
<PackageVersion Include="FluentAssertions" Version="6.12.0" />
<PackageVersion Include="Moq" Version="4.20.72" />
<PackageVersion Include="NSubstitute" Version="5.3.0" />

<!-- Source Link Support -->
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="8.0.0" />

<!-- Versioning -->
<PackageVersion Include="Nerdbank.GitVersioning" Version="3.6.146" />
</ItemGroup>
</Project>
</Project>
12 changes: 7 additions & 5 deletions src/Microsoft.Agents.A365.DevTools.Cli/Commands/DeployCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

using System.CommandLine;
using Microsoft.Agents.A365.DevTools.Cli.Constants;
using Microsoft.Agents.A365.DevTools.Cli.Exceptions;
using Microsoft.Agents.A365.DevTools.Cli.Helpers;
using Microsoft.Agents.A365.DevTools.Cli.Models;
using Microsoft.Agents.A365.DevTools.Cli.Services;
using Microsoft.Extensions.Logging;
using System.CommandLine;

namespace Microsoft.Agents.A365.DevTools.Cli.Commands;

Expand Down Expand Up @@ -90,7 +91,7 @@ public static Command CreateCommand(
logger.LogInformation("Step 2: Start deploying Agent 365 Tool Permissions...");
await DeployMcpToolPermissionsAsync(validatedConfig, executor, logger);
}
catch (FileNotFoundException ex)
catch (Exception ex)
{
HandleDeploymentException(ex, logger);
}
Expand Down Expand Up @@ -158,7 +159,7 @@ private static Command CreateAppSubcommand(

await DeployApplicationAsync(validatedConfig, deploymentService, verbose, inspect, restart, logger);
}
catch (FileNotFoundException ex)
catch (Exception ex)
{
HandleDeploymentException(ex, logger);
}
Expand Down Expand Up @@ -464,8 +465,9 @@ private static void HandleDeploymentException(Exception ex, ILogger logger)
logger.LogInformation("");
break;
default:
logger.LogError(ex, "Deployment failed: {Message}", ex.Message);
break;
logger.LogError("Deployment failed: {Message}", ex.Message);

throw new DeployAppException($"Deployment failed: {ex.Message}", ex);
}
}
}
Expand Down
Loading
Loading