fix(setup): trim trailing hyphens from endpoint names

[sellakumaran]

Summary

Fixes endpoint registration failures when long hostnames (e.g., ngrok free domains) are truncated to 42 characters and end with trailing hyphens, causing Azure Bot Service to reject them with InternalServerError.

Changes

• EndpointHelper.GetEndpointName(): Trims trailing hyphens after truncating to 42 characters
• Input validation: Added null/whitespace checks with SetupValidationException
• CleanupCommand: Fixed to display the actual truncated endpoint name in cleanup preview
• Test coverage: Added 12 comprehensive tests including edge cases and exception scenarios

Test Results

• ✅ All 12 EndpointHelper tests passing
• ✅ End-to-end tested with ngrok free domain
• ✅ Before fix: distressingly-gnathonic-alonzo-ngrok-free- (ends with hyphen) → InternalServerError
• ✅ After fix: distressingly-gnathonic-alonzo-ngrok-free (no hyphen) → Success

Root Cause

When needDeployment: false and a long messagingEndpoint is provided:

1. Hostname like distressingly-gnathonic-alonzo.ngrok-free.app becomes distressingly-gnathonic-alonzo-ngrok-free-app-endpoint (54 chars)
2. Truncated to 42 chars: distressingly-gnathonic-alonzo-ngrok-free-
3. Azure Bot Service rejects names ending with hyphens per naming constraints

Resolves

Partner issue: endpoint registration failures with long ngrok URLs

[github-actions]

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[Copilot]

Pull request overview

This pull request fixes endpoint registration failures when long hostnames (such as ngrok free domains) are truncated to 42 characters and end with trailing hyphens, which Azure Bot Service rejects. The fix ensures endpoint names comply with Azure Bot Service naming constraints by trimming trailing hyphens after truncation and adding comprehensive validation.

Changes:

• Enhanced EndpointHelper.GetEndpointName() to trim trailing hyphens after truncation and validate input/output
• Fixed CleanupCommand to display the actual truncated endpoint name in the cleanup preview
• Added 12 comprehensive unit tests covering normal operations, edge cases, and exception scenarios

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/Microsoft.Agents.A365.DevTools.Cli/Services/Helpers/EndpointHelper.cs	Added input validation, trailing hyphen trimming logic, and minimum length validation to ensure Azure Bot Service naming compliance
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Services/Helpers/EndpointHelperTests.cs	Added comprehensive test suite with 12 tests covering all scenarios including truncation, hyphen trimming, validation, and exception cases
src/Microsoft.Agents.A365.DevTools.Cli/Commands/CleanupCommand.cs	Fixed cleanup preview to show the actual endpoint name that will be used for deletion (after truncation and hyphen trimming)