Merged
Conversation
Simplified the `deploy` command to focus solely on application deployment. Introduced new subcommands: `a365 deploy scopes` for non-mcp scopes. Updated the README to document these changes and the new flags (`--dry-run`, `--inspect`, `--restart`, `--verbose`). Enhanced error handling with `DeployMcpException` and `DeployScopesException` for structured diagnostics. Added new error codes for `mcp` and `scopes` deployment failures. Refactored `GraphApiService` to improve handling of inheritable permissions, added the `GraphPostWithResponseAsync` method, and introduced dependency injection for better testability. Added unit tests for `GraphApiService` to validate new functionality. Improved logging, modularized code, and aligned the CLI structure with the updated `deploy` command behavior.
- Added `GraphApiService` as a dependency in `DeployCommand` and subcommands for modular Graph API interactions. - Introduced `IMicrosoftGraphTokenProvider` for delegated token acquisition, supporting dynamic scope requests. - Refactored `SetInheritablePermissionsAsync` to `SetInheritablePermissionsAsyncV2` with additional scope support. - Added `EnsureApplicationHasRequiredPermissionsAsync` to manage app resource access declarations. - Introduced `AdminConsentHelper` for reusable admin consent polling logic. - Updated `A365SetupRunner` to use `AdminConsentHelper` for consistency. - Enhanced dependency injection in `Program.cs` to register new services. - Added unit tests for `AdminConsentHelper` and updated tests for `DeployCommand`. - Improved error handling, logging, and modularity across the codebase. - Reorganized dependency registration and improved test coverage for new features.
mengyimicro
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a365 deploy scopes- Grant or update OAuth2 scopes for a specific resource app ID on the agent blueprint.