Skip to content

Adding support for configuring Messaging Endpoint#35

Merged
sellakumaran merged 5 commits intomainfrom
users/magurusa/endpointConfig
Nov 21, 2025
Merged

Adding support for configuring Messaging Endpoint#35
sellakumaran merged 5 commits intomainfrom
users/magurusa/endpointConfig

Conversation

@skg-marimuthu
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings November 20, 2025 17:53
@skg-marimuthu skg-marimuthu requested review from a team as code owners November 20, 2025 17:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for configuring a messaging endpoint as an alternative to deploying an Azure Web App for Agent 365 agents. This allows developers to use externally hosted agents while still registering them with the Agent 365 platform.

Key Changes

  • Added MessagingEndpoint property to Agent365Config as an optional alternative to WebAppName/AppServicePlanName
  • Modified validation logic to make App Service fields optional when MessagingEndpoint is provided
  • Updated configuration wizard to prompt users whether to create a Web App or provide an external messaging endpoint
  • Changed AppServicePlanSku default from "B1" to empty string to align with optional App Service fields

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
src/Microsoft.Agents.A365.DevTools.Cli/Models/Agent365Config.cs Added MessagingEndpoint property, updated validation logic to make App Service fields conditional, changed AppServicePlanSku default to empty string
src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupCommand.cs Added ExtractWebAppNameFromUrl helper, updated endpoint registration to support both Web App and MessagingEndpoint configurations
src/Microsoft.Agents.A365.DevTools.Cli/Services/ConfigurationWizardService.cs Added prompts for Web App creation choice and messaging endpoint URL, updated configuration builder to handle both deployment scenarios
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Models/Agent365ConfigTests.cs Added comprehensive tests for MessagingEndpoint validation scenarios, removed obsolete AppServicePlanSku default assertion
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Commands/SetupCommandTests.cs Added tests for ExtractWebAppNameFromUrl method with port numbers in URLs
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Commands/ConfigCommandStaticDynamicSeparationTests.cs Added test to verify MessagingEndpoint is properly saved as a static property in configuration

Copilot AI review requested due to automatic review settings November 21, 2025 07:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

src/Microsoft.Agents.A365.DevTools.Cli/Services/A365SetupRunner.cs:136

        var messagingEndpoint = Get("messagingEndpoint");

Refactored CleanupCommand to improve condition handling for App Service Plan deletion and introduced `config.NeedDeployment` for Web App deletion logic. Simplified DeployCommand by replacing `ShouldSkipWebAppDeployment` with a direct condition check.

Updated SetupCommand to persist configuration changes and removed unused methods. Introduced `DefaultAppServicePlanSku` constant in ConfigConstants and replaced hardcoded defaults across files. Changed default `Environment` in Agent365Config to "prod" and improved validation logic.

Replaced asynchronous prompts in ConfigurationWizardService with synchronous methods for simplicity. Removed redundant code and unused imports across the codebase for better maintainability.
mengyimicro
mengyimicro previously approved these changes Nov 21, 2025
Copilot AI review requested due to automatic review settings November 21, 2025 22:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@sellakumaran sellakumaran merged commit 1190f94 into main Nov 21, 2025
2 checks passed
@sellakumaran sellakumaran deleted the users/magurusa/endpointConfig branch November 21, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants