Adding support for configuring Messaging Endpoint#35
Merged
sellakumaran merged 5 commits intomainfrom Nov 21, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for configuring a messaging endpoint as an alternative to deploying an Azure Web App for Agent 365 agents. This allows developers to use externally hosted agents while still registering them with the Agent 365 platform.
Key Changes
- Added
MessagingEndpointproperty toAgent365Configas an optional alternative toWebAppName/AppServicePlanName - Modified validation logic to make App Service fields optional when
MessagingEndpointis provided - Updated configuration wizard to prompt users whether to create a Web App or provide an external messaging endpoint
- Changed
AppServicePlanSkudefault from "B1" to empty string to align with optional App Service fields
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.Agents.A365.DevTools.Cli/Models/Agent365Config.cs | Added MessagingEndpoint property, updated validation logic to make App Service fields conditional, changed AppServicePlanSku default to empty string |
| src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupCommand.cs | Added ExtractWebAppNameFromUrl helper, updated endpoint registration to support both Web App and MessagingEndpoint configurations |
| src/Microsoft.Agents.A365.DevTools.Cli/Services/ConfigurationWizardService.cs | Added prompts for Web App creation choice and messaging endpoint URL, updated configuration builder to handle both deployment scenarios |
| src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Models/Agent365ConfigTests.cs | Added comprehensive tests for MessagingEndpoint validation scenarios, removed obsolete AppServicePlanSku default assertion |
| src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Commands/SetupCommandTests.cs | Added tests for ExtractWebAppNameFromUrl method with port numbers in URLs |
| src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Commands/ConfigCommandStaticDynamicSeparationTests.cs | Added test to verify MessagingEndpoint is properly saved as a static property in configuration |
src/Microsoft.Agents.A365.DevTools.Cli/Services/ConfigurationWizardService.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Services/ConfigurationWizardService.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupCommand.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Commands/SetupCommandTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Models/Agent365Config.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/CleanupCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/CreateInstanceCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/DeployCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Services/A365SetupRunner.cs
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (1)
src/Microsoft.Agents.A365.DevTools.Cli/Services/A365SetupRunner.cs:136
- This assignment to messagingEndpoint is useless, since its value is never read.
var messagingEndpoint = Get("messagingEndpoint");
src/Microsoft.Agents.A365.DevTools.Cli/Services/A365SetupRunner.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/CreateInstanceCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Services/ConfigurationWizardService.cs
Show resolved
Hide resolved
Refactored CleanupCommand to improve condition handling for App Service Plan deletion and introduced `config.NeedDeployment` for Web App deletion logic. Simplified DeployCommand by replacing `ShouldSkipWebAppDeployment` with a direct condition check. Updated SetupCommand to persist configuration changes and removed unused methods. Introduced `DefaultAppServicePlanSku` constant in ConfigConstants and replaced hardcoded defaults across files. Changed default `Environment` in Agent365Config to "prod" and improved validation logic. Replaced asynchronous prompts in ConfigurationWizardService with synchronous methods for simplicity. Removed redundant code and unused imports across the codebase for better maintainability.
mengyimicro
previously approved these changes
Nov 21, 2025
mengyimicro
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.