Skip to content

Refactor setup into subcommands#38

Merged
Josina20 merged 21 commits intomainfrom
users/josjoy/setup_subcommands
Nov 25, 2025
Merged

Refactor setup into subcommands#38
Josina20 merged 21 commits intomainfrom
users/josjoy/setup_subcommands

Conversation

@Josina20
Copy link
Contributor

@Josina20 Josina20 commented Nov 20, 2025

Unit tests in follow up PR
image

@Josina20 Josina20 marked this pull request as ready for review November 22, 2025 01:46
@Josina20 Josina20 requested review from a team as code owners November 22, 2025 01:46
Copilot AI review requested due to automatic review settings November 22, 2025 01:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the monolithic setup command into granular subcommands, providing better control over the Agent 365 environment setup process. The change replaces a single command with five distinct subcommands: infrastructure, blueprint, permissions (with mcp/bot sub-subcommands), endpoint, and all.

Key Changes:

  • Deleted the 1799-line A365SetupRunner.cs and distributed its logic across focused subcommand files
  • Restructured tests to align with new subcommand architecture
  • Added helper classes for shared functionality (SetupHelpers, SetupResults)

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
SetupCommandTests.cs Updated tests to verify subcommand structure and dry-run functionality instead of monolithic setup
A365SetupRunner.cs Deleted - functionality distributed to subcommands
Program.cs Removed unnecessary blank line in error handling
BotConfigurator.cs Added blank lines for improved readability in error handling
SetupResults.cs New helper class to track setup step results for summary reporting
SetupHelpers.cs New shared utilities for verification display, summaries, and permission configuration
PermissionsSubcommand.cs New subcommand implementing MCP and Bot API permission configuration
InfrastructureSubcommand.cs New subcommand implementing Azure resource provisioning (Phase 0-1 from old runner)
EndpointSubcommand.cs New subcommand implementing messaging endpoint registration
BlueprintSubcommand.cs New subcommand implementing agent blueprint creation (Phase 2 from old runner)
AllSubcommand.cs New orchestrator subcommand that runs all setup steps sequentially
SetupCommand.cs Refactored from 714 lines to 59 lines - now registers subcommands instead of containing logic

@Josina20 Josina20 changed the title Users/josjoy/setup subcommands Refactor setup into subcommands Nov 24, 2025
Copilot AI review requested due to automatic review settings November 24, 2025 22:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 10 comments.

Copilot AI review requested due to automatic review settings November 25, 2025 00:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 10 comments.

@Josina20 Josina20 merged commit 596f429 into main Nov 25, 2025
1 of 2 checks passed
@pontemonti pontemonti deleted the users/josjoy/setup_subcommands branch December 5, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants