Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces initial CLI functionality for the Agent365 DevTools CLI, implementing core configuration management, service layer architecture, and comprehensive test coverage for the developer tools.
Key Changes:
- Added configuration service with two-file model (static + generated state)
- Implemented multi-platform deployment services (DotNet, Node.js, Python)
- Created comprehensive test suite with 2,000+ lines of unit and integration tests
- Added Azure service integrations (authentication, deployment, bot configuration)
Reviewed Changes
Copilot reviewed 76 out of 93 changed files in this pull request and generated 34 comments.
Show a summary per file
| File | Description |
|---|---|
Microsoft.Agents.A365.DevTools.Cli.Tests.csproj |
Test project configuration with xUnit, Moq, and FluentAssertions dependencies |
McpServerConfigTests.cs |
Unit tests for MCP server configuration model validation and serialization |
Agent365ConfigTests.cs |
Tests for static/dynamic configuration properties and JSON serialization |
ScopeIntegrationTests.cs |
Integration tests for MCP server scope and audience flow |
ProjectSettingsSyncHelperTests.cs |
Tests for syncing settings across DotNet, Python, and Node.js projects |
ManifestHelperTests.cs |
Tests for manifest creation and server object generation |
TestConstants.cs |
Centralized test constants for consistent test data |
AuthenticationConstantsTests.cs |
Validation tests for authentication constants |
SetupCommandTests.cs |
Tests for setup command dry-run functionality |
QueryEntraCommandTests.cs |
Tests for Entra query command structure |
DevelopCommandTests.cs |
Tests for develop command with MCP server management |
DeployCommandTests.cs |
Tests for deployment command structure |
CreateInstanceCommandTests.cs |
Tests for instance creation command |
ConfigCommandTests.cs |
Tests for configuration management commands |
CleanupCommandTests.cs |
Tests for cleanup command with interactive confirmation |
Directory.Build.props |
Test project build configuration |
| Service files (PythonBuilder.cs, NodeBuilder.cs, etc.) | Platform-specific build and deployment implementations |
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Models/McpServerConfigTests.cs
Show resolved
Hide resolved
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Models/Agent365ConfigTests.cs
Show resolved
Hide resolved
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Integration/ScopeIntegrationTests.cs
Show resolved
Hide resolved
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Helpers/ProjectSettingsSyncHelperTests.cs
Show resolved
Hide resolved
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Helpers/ManifestHelperTests.cs
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Services/AzureEnvironmentValidator.cs
Show resolved
Hide resolved
...sts/Microsoft.Agents.A365.DevTools.Cli.Tests/Microsoft.Agents.A365.DevTools.Cli.Tests.csproj
Show resolved
Hide resolved
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Models/McpServerConfigTests.cs
Show resolved
Hide resolved
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Models/Agent365ConfigTests.cs
Show resolved
Hide resolved
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Integration/ScopeIntegrationTests.cs
Show resolved
Hide resolved
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Helpers/ProjectSettingsSyncHelperTests.cs
Show resolved
Hide resolved
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Models/Agent365ConfigTests.cs
Show resolved
Hide resolved
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Models/Agent365ConfigTests.cs
Show resolved
Hide resolved
docs/contributing/implementation-notes/config-init-mandatory-fields.md
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/ConfigCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/ConfigCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/CreateInstanceCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/CreateInstanceCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Services/GraphApiService.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 75 out of 92 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
src/Microsoft.Agents.A365.DevTools.Cli/Services/GraphApiService.cs:1
- Exception is logged with Debug level and generic message. When token cache read fails, this should be logged as a warning or info since it's a normal scenario (cache might not exist yet), and the message should clarify this is expected: 'Token cache file not found or unreadable - will acquire fresh token'.
// Copyright (c) Microsoft Corporation.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 75 out of 92 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Commands/ConfigCommandTests.cs:1
- The bullet character '�' appears to be a unicode character that may not render correctly. Consider using a standard ASCII character like '-' or '*' for better compatibility.
// Copyright (c) Microsoft Corporation.
|
@sellakumaran I've opened a new pull request, #5, to work on those changes. Once the pull request is ready, I'll request review from you. |
No description provided.