Skip to content

Fix malformed bullet point characters in error messages and logs #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix malformed bullet point characters in error messages and logs #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7980753
Initial plan
Copilot Nov 13, 2025
731bf61
Fix bullet point characters: replace � with • in log messages and err…
Copilot Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 23 additions & 23 deletions src/Microsoft.Agents.A365.DevTools.Cli/Exceptions/Agent365Exception.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,13 @@ private static string BuildMessage(string errorCode, string issueDescription, Li
var sb = new StringBuilder();
sb.Append($"[{errorCode}] {issueDescription}");

if (errorDetails?.Count > 0)
{
sb.AppendLine();
foreach (var detail in errorDetails)
{
sb.AppendLine($" � {detail}");
}
if (errorDetails?.Count > 0)
{
sb.AppendLine();
foreach (var detail in errorDetails)
{
sb.AppendLine($" • {detail}");
}
}

return sb.ToString();
Expand All @@ -99,14 +99,14 @@ public virtual string GetFormattedMessage()
sb.AppendLine($"Error: {IssueDescription}");
sb.AppendLine();

// Error details
if (ErrorDetails.Count > 0)
{
foreach (var detail in ErrorDetails)
{
sb.AppendLine($" � {detail}");
}
sb.AppendLine();
// Error details
if (ErrorDetails.Count > 0)
{
foreach (var detail in ErrorDetails)
{
sb.AppendLine($" • {detail}");
}
sb.AppendLine();
}

// Mitigation steps
Expand All @@ -121,14 +121,14 @@ public virtual string GetFormattedMessage()
}

// Context information
if (Context.Count > 0)
{
sb.AppendLine("Context:");
foreach (var kvp in Context)
{
sb.AppendLine($" � {kvp.Key}: {kvp.Value}");
}
sb.AppendLine();
if (Context.Count > 0)
{
sb.AppendLine("Context:");
foreach (var kvp in Context)
{
sb.AppendLine($" • {kvp.Key}: {kvp.Value}");
}
sb.AppendLine();
}

return sb.ToString();
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Agents.A365.DevTools.Cli/Exceptions/ConfigurationValidationException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ private static List<string> BuildMitigationSteps(string configFilePath, List<Val
{
steps.Add("");
steps.Add("Common Azure naming rules:");
steps.AddRange(contextualHelp.Select(h => $" � {h}"));
steps.AddRange(contextualHelp.Select(h => $" • {h}"));
steps.Add("");
steps.Add("See Azure naming conventions: https://learn.microsoft.com/azure/azure-resource-manager/management/resource-name-rules");
}
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.Agents.A365.DevTools.Cli/Services/ConfigService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ public async Task<Agent365Config> LoadAsync(
_logger?.LogError("Configuration validation failed:");
foreach (var error in validationResult.Errors)
{
_logger?.LogError(" � {Error}", error);
_logger?.LogError(" • {Error}", error);
}

// Convert validation errors to structured exception
Expand All @@ -328,7 +328,7 @@ public async Task<Agent365Config> LoadAsync(
{
foreach (var warning in validationResult.Warnings)
{
_logger?.LogWarning(" � {Warning}", warning);
_logger?.LogWarning(" • {Warning}", warning);
}
}

Expand Down