Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a modular deployment system for the Agent365 DevTools CLI with separate subcommands for application and MCP tool permission deployment. The changes add a365 deploy app and a365 deploy mcp subcommands while maintaining backward compatibility with the main a365 deploy command that runs both operations sequentially.
Key Changes:
- Added new
GraphDeleteAsyncandReplaceOauth2PermissionGrantAsyncmethods to GraphApiService for OAuth2 permission management - Refactored DeployCommand to extract reusable helper methods (ValidateDeploymentPrerequisitesAsync, DeployApplicationAsync, DeployMcpToolPermissionsAsync)
- Standardized logging bullet points from
•to-across multiple files for consistency
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.Agents.A365.DevTools.Cli/Services/GraphApiService.cs | Added GraphDeleteAsync and ReplaceOauth2PermissionGrantAsync methods for OAuth2 permission grant management with delete-and-recreate semantics |
| src/Microsoft.Agents.A365.DevTools.Cli/Commands/DeployCommand.cs | Refactored into main command and two subcommands (app, mcp) with extracted helper methods for deployment validation and execution |
| src/Microsoft.Agents.A365.DevTools.Cli/Services/A365SetupRunner.cs | Updated logging bullet points from • to - for consistency |
| src/Microsoft.Agents.A365.DevTools.Cli/Services/A365CreateInstanceRunner.cs | Updated logging bullet points from • to - and refined variable naming from "agent identity" to "agentic app" |
| src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupCommand.cs | Updated logging bullet points from • to - for consistency |
| src/Microsoft.Agents.A365.DevTools.Cli/Commands/CreateInstanceCommand.cs | Updated comments and variable names to use "agentic app" terminology consistently |
| docs/commands/deploy.md | Added comprehensive documentation for the deploy command and its new subcommands |
| docs/commands/config-init.md | Updated example to use a365 deploy app instead of a365 deploy |
| README.md | Added documentation for new a365 deploy app and a365 deploy mcp subcommands |
src/Microsoft.Agents.A365.DevTools.Cli/Commands/CreateInstanceCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/DeployCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Services/GraphApiService.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Services/GraphApiService.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/CreateInstanceCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/CreateInstanceCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Services/GraphApiService.cs
Outdated
Show resolved
Hide resolved
sellakumaran
previously approved these changes
Nov 14, 2025
tmlsousa
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Deploy MCP subcommands and refactor deployment architecture
This commit introduces a modular deployment system for the Agent365 DevTools CLI
with separate subcommands for application and MCP tool permission deployment.
Key Features Added:
New Subcommands:
a365 deploy app- Deploy only application binaries to Azure App Servicea365 deploy mcp- Deploy/update only MCP server scopes and permissionsa365 deploycommand now performs both operations sequentiallyArchitecture Improvements:
MCP Integration:
Enhanced User Experience:
Code Quality: