-
Notifications
You must be signed in to change notification settings - Fork 10
Add User.Read scope for /me Graph call #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
102 changes: 102 additions & 0 deletions
102
...sts/Microsoft.Agents.A365.DevTools.Cli.Tests/Services/InteractiveGraphAuthServiceTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT License. | ||
|
|
||
| using Microsoft.Agents.A365.DevTools.Cli.Services; | ||
| using Microsoft.Extensions.Logging; | ||
| using NSubstitute; | ||
| using Xunit; | ||
|
|
||
| namespace Microsoft.Agents.A365.DevTools.Cli.Tests.Services; | ||
|
|
||
| public class InteractiveGraphAuthServiceTests | ||
| { | ||
| /// <summary> | ||
| /// This test ensures that all required Graph API scopes are present in the RequiredScopes array. | ||
| /// If any of these scopes are removed, the test will fail to prevent accidental permission reduction. | ||
| /// | ||
| /// These scopes are critical for Agent Blueprint creation and inheritable permissions configuration: | ||
| /// - Application.ReadWrite.All: Required for creating and managing app registrations | ||
| /// - AgentIdentityBlueprint.ReadWrite.All: Required for Agent Blueprint operations | ||
| /// - AgentIdentityBlueprint.UpdateAuthProperties.All: Required for updating blueprint auth properties | ||
| /// - User.Read: Basic user profile access for authentication context | ||
| /// </summary> | ||
| [Fact] | ||
| public void RequiredScopes_MustContainAllEssentialPermissions() | ||
| { | ||
| // Arrange | ||
| var expectedScopes = new[] | ||
| { | ||
| "https://graph.microsoft.com/Application.ReadWrite.All", | ||
| "https://graph.microsoft.com/AgentIdentityBlueprint.ReadWrite.All", | ||
| "https://graph.microsoft.com/AgentIdentityBlueprint.UpdateAuthProperties.All", | ||
| "https://graph.microsoft.com/User.Read" | ||
| }; | ||
|
|
||
| var logger = Substitute.For<ILogger<InteractiveGraphAuthService>>(); | ||
| var service = new InteractiveGraphAuthService(logger, "12345678-1234-1234-1234-123456789abc"); | ||
joratz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| // Act - Use reflection to access the private static RequiredScopes field | ||
| var requiredScopesField = typeof(InteractiveGraphAuthService) | ||
| .GetField("RequiredScopes", System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Static); | ||
|
|
||
| Assert.NotNull(requiredScopesField); | ||
| var actualScopes = (string[])requiredScopesField.GetValue(null)!; | ||
|
|
||
| // Assert | ||
| Assert.NotNull(actualScopes); | ||
| Assert.Equal(expectedScopes.Length, actualScopes.Length); | ||
|
|
||
| foreach (var expectedScope in expectedScopes) | ||
| { | ||
| Assert.Contains(expectedScope, actualScopes); | ||
| } | ||
| } | ||
|
|
||
| [Fact] | ||
| public void Constructor_WithValidGuidClientAppId_ShouldSucceed() | ||
| { | ||
| // Arrange | ||
| var logger = Substitute.For<ILogger<InteractiveGraphAuthService>>(); | ||
| var validGuid = "12345678-1234-1234-1234-123456789abc"; | ||
|
|
||
| // Act & Assert - Should not throw | ||
| var service = new InteractiveGraphAuthService(logger, validGuid); | ||
| Assert.NotNull(service); | ||
| } | ||
|
|
||
| [Theory] | ||
| [InlineData(null)] | ||
| [InlineData("")] | ||
| [InlineData(" ")] | ||
| public void Constructor_WithNullOrEmptyClientAppId_ShouldThrowArgumentNullException(string? clientAppId) | ||
| { | ||
| // Arrange | ||
| var logger = Substitute.For<ILogger<InteractiveGraphAuthService>>(); | ||
|
|
||
| // Act & Assert | ||
| Assert.Throws<ArgumentNullException>(() => new InteractiveGraphAuthService(logger, clientAppId!)); | ||
| } | ||
|
|
||
| [Theory] | ||
| [InlineData("not-a-guid")] | ||
| [InlineData("12345")] | ||
| [InlineData("invalid-format")] | ||
| public void Constructor_WithInvalidGuidClientAppId_ShouldThrowArgumentException(string clientAppId) | ||
| { | ||
| // Arrange | ||
| var logger = Substitute.For<ILogger<InteractiveGraphAuthService>>(); | ||
|
|
||
| // Act & Assert | ||
| Assert.Throws<ArgumentException>(() => new InteractiveGraphAuthService(logger, clientAppId)); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void Constructor_WithNullLogger_ShouldThrowArgumentNullException() | ||
| { | ||
| // Arrange | ||
| var validGuid = "12345678-1234-1234-1234-123456789abc"; | ||
|
|
||
| // Act & Assert | ||
| Assert.Throws<ArgumentNullException>(() => new InteractiveGraphAuthService(null!, validGuid)); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.