[Observability] Do not set target agent/caller UPN attribute when using turn context #184
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects the observability telemetry implementation by removing incorrect UPN attribute assignments from turn context extraction methods. The "Name" property from turn context activities contains display names, not User Principal Names (UPNs), which have specific downstream uses and certification requirements.
Changes:
- Removed incorrect
GenAiCallerUpnKeyassignment fromGetCallerBaggagePairsmethod - Removed incorrect
GenAiAgentUPNKeyassignment fromGetTargetAgentBaggagePairsmethod
juliomenendez
previously approved these changes
Jan 16, 2026
fpfp100
previously approved these changes
Jan 16, 2026
This reverts commit 5fe7fa6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Today we set the caller and agent UPN attribute values to the "Name" from turnContext. This is not a UPN. These fields have specific downstream uses. Not setting a valid UPN breaks them.
What?
Just dont set the value of UPN. This way it can be identified as a missing attributes during certification, and the agent developer can get it via a graph call or any other mechanism and set it to a valid value.