feat: replace ts-node with tsx in sample packages and update pnpm workspace #154
+328
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kspace - Added Product Requirements Document for replacing ts-node with tsx. - Updated pnpm workspace catalog to include tsx and remove ts-node. - Modified basic-agent-sdk-sample and openai-agent-auto-instrument-sample to use tsx for development scripts. - Updated package.json files to reflect changes in devDependencies from ts-node to tsx. - Ensured nodemon integration works with tsx.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the test/sample packages from ts-node to tsx for TypeScript execution in development workflows, and updates the pnpm workspace catalog/lockfile accordingly.
Changes:
- Replaced
ts-nodewithtsxin sampledev/test:setupscripts (including nodemon integration). - Updated pnpm workspace catalog to add
tsxand removets-node, regeneratingpnpm-lock.yaml. - Added PRD documentation and an implementation task list for the migration.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests-agent/openai-agent-auto-instrument-sample/package.json | Switches dev and test:setup scripts to tsx; updates devDependency to tsx. |
| tests-agent/basic-agent-sdk-sample/package.json | Switches dev script to tsx; replaces ts-node devDependency with tsx. |
| pnpm-workspace.yaml | Updates workspace catalog to include tsx instead of ts-node. |
| pnpm-lock.yaml | Reflects catalog change and adds tsx dependency graph entries. |
| docs/prd/replace-ts-node-with-tsx.md | Adds PRD describing the motivation, scope, and verification plan for the migration. |
| docs/prd/replace-ts-node-with-tsx-tasks.md | Adds a task checklist for executing and verifying the migration. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ts-node does not appear to be maintained; the suggested replacement is tsx where there is still active development. This PR replaces ts-node with tsx.